Merge pull request #81 from microsoft/fix/empty-profile-error

fix: don't error out on empty profile

Author: connor4312

.eslintrc.js

@@ -16,7 +16,6 @@ module.exports = {
   rules: {
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/interface-name-prefix': ['error', { prefixWithI: 'always' }],
     'react/display-name': 'off',
     'react/prop-types': 'off',
     'header/header': [

lerna.json

@@ -2,5 +2,5 @@
   "packages": [
     "packages/*"
   ],
-  "version": "1.0.2"
+  "version": "1.0.3"
 }

packages/vscode-js-profile-core/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "vscode-js-profile-core",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "sideEffects": false,
   "private": true,
   "scripts": {

packages/vscode-js-profile-core/package.json

@@ -11,6 +11,17 @@ describe('model', () => {
       expect(buildModel(profiles[i])).toMatchSnapshot();
     });
   }
+
+  it('does not error on empty, profile', () => {
+    buildModel({
+      nodes: [],
+      samples: [],
+      timeDeltas: [],
+      startTime: 1654100488066000,
+      endTime: 1654100490779000,
+      $vscode: { rootPath: '.', locations: [] },
+    });
+  });
 });
 
 const profiles = [

packages/vscode-js-profile-core/src/cpu/model.test.ts

@@ -229,8 +229,10 @@ export const buildModel = (profile: ICpuProfileRaw): IProfileModel => {
   // time before the first sample, and the time of the last sample is only
   // derived (approximately) by the missing time in the sum of deltas. Save
   // some work by calculating it here.
-  nodes[mapId(samples[timeDeltas.length - 1])].selfTime += lastNodeTime;
-  timeDeltas.push(lastNodeTime);
+  if (nodes.length) {
+    nodes[mapId(samples[timeDeltas.length - 1])].selfTime += lastNodeTime;
+    timeDeltas.push(lastNodeTime);
+  }
 
   // 3. Add the aggregate times for all node children and locations
   for (let i = 0; i < nodes.length; i++) {

packages/vscode-js-profile-core/src/cpu/model.ts

@@ -1,7 +1,7 @@
 {
   "name": "vscode-js-profile-flame",
   "displayName": "Flame Chart Visualizer for JavaScript Profiles",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Flame graph visualizer for profiles taken from the JavaScript debugger",
   "author": "Connor Peet <[email protected]>",
   "homepage": "https://github.com/microsoft/vscode-js-profile-visualizer#readme",
@@ -169,7 +169,7 @@
   "dependencies": {
     "@vscode/codicons": "^0.0.30",
     "chroma-js": "^2.4.2",
-    "vscode-js-profile-core": "^1.0.2",
+    "vscode-js-profile-core": "^1.0.3",
     "vscode-webview-tools": "^0.1.1"
   }
 }

packages/vscode-js-profile-flame/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "vscode-js-profile-table",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "displayName": "Table Visualizer for JavaScript Profiles",
   "description": "Text visualizer for profiles taken from the JavaScript debugger",
   "author": "Connor Peet <[email protected]>",
@@ -86,6 +86,6 @@
   },
   "dependencies": {
     "@vscode/codicons": "^0.0.28",
-    "vscode-js-profile-core": "^1.0.2"
+    "vscode-js-profile-core": "^1.0.3"
   }
 }