Skip to content

SCSS emmet is more aggressive than previous versions #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoyo930021 opened this issue Dec 7, 2020 · 2 comments
Closed

SCSS emmet is more aggressive than previous versions #42

yoyo930021 opened this issue Dec 7, 2020 · 2 comments
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2021

Comments

@yoyo930021
Copy link

yoyo930021 commented Dec 7, 2020 •
edited
Loading

From: vuejs/vetur#2522

In v2.0.9, the doComplete return null when I input marginright.
In v2.1.2, the doComplete return marginright: | completion when I input marginright.

Is it a correct result?
@yoyo930021 yoyo930021 changed the title SCSS emmet is broken in v2.1.2 SCSS emmet more aggressive than previous versions Dec 7, 2020
@yoyo930021 yoyo930021 changed the title SCSS emmet more aggressive than previous versions SCSS emmet is more aggressive than previous versions Dec 7, 2020
@rzhao271
Copy link
Contributor

That doesn't look right to me.
I'm currently upgrading this package to use emmetio/emmet v2.3.0 instead of v2.1.6 and then I'll check to see what's happening

Will mark this issue as a bug for now.

@rzhao271 rzhao271 self-assigned this Dec 30, 2020
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Dec 30, 2020
@rzhao271
Copy link
Contributor

Should be fixed in v2.2.1.

@rzhao271 rzhao271 added this to the January 2021 milestone Jan 25, 2021
@rebornix rebornix added the verified Verification succeeded label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
3 participants
@rebornix @rzhao271 @yoyo930021