Skip to content

Run configured package manager verify signatures #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timotheeguerin opened this issue Mar 5, 2025 · 1 comment
Open

Run configured package manager verify signatures #6277

timotheeguerin opened this issue Mar 5, 2025 · 1 comment
Labels
compiler:core Issues for @typespec/compiler feature New feature or request triaged:core
Milestone

Comments

@timotheeguerin
Copy link
Member

The initial implementation #6220 doesn't verify the signature of the downloaded package.

The concern is that corepack today include the registry keys in their codebase which means when rotated any older version is now broken(without passing the flag to ignore key validation) nodejs/corepack#616

Seems like a suggested solution is to use the npm approach to call tuf sigtool to retrieve teh keys with a fallback on downloading them from npm registry (with potentially logging a warning to the user)

npm implementation
https://github.com/npm/cli/blob/593c84921b0df963cef2ca7b13e44acc20cbd558/lib/utils/verify-signatures.js#L178-L191

@timotheeguerin timotheeguerin added the compiler:core Issues for @typespec/compiler label Mar 5, 2025
@markcowl markcowl modified the milestones: [2025] May, Backlog Mar 17, 2025
@markcowl markcowl added the feature New feature or request label Mar 17, 2025
@markcowl
Copy link
Contributor

est: 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:core Issues for @typespec/compiler feature New feature or request triaged:core
Projects
None yet
Development

No branches or pull requests

2 participants