Try to get the client name during DefTerm handoff #19014
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lhecker
reviewed
Jun 24, 2025
| try | ||
| { | ||
| auto processImageName{ wil::QueryFullProcessImageNameW<std::wstring>(_piClient.hProcess) }; | ||
| _clientName = std::filesystem::path{ processImageName }.filename().wstring(); |
There was a problem hiding this comment.
(which thing will we move? i guess we could move all of it)
There was a problem hiding this comment.
presumably path{ move(image) }; everything else is an rvalue
lhecker
approved these changes
Jun 24, 2025
DHowett
added a commit
that referenced
this pull request
Jun 24, 2025
(cherry picked from commit cf95460) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgbO1vA Service-Version: 1.22
DHowett
added a commit
that referenced
this pull request
Jun 24, 2025
(cherry picked from commit cf95460) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgbO1u8 Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.