Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions #11322

Open
WretchedDade opened this issue Apr 1, 2025 · 1 comment · May be fixed by #11324
Open
Assignees
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code

Comments

@WretchedDade
Copy link

WretchedDade commented Apr 1, 2025

Describe the bug
When using the kernel.CreatePluginFromPromptDirectoryYaml(...) method, if the files you are trying to load are using the .yml extension instead of .yaml, the files are not loaded.

To Reproduce

  1. Create a valid YAML prompt template with a .yml extension in a folder
  2. Try to create a plugin for that folder
  3. Notice that the plugin is loaded without any functions

Expected behavior
Ideally, the method would support both file extensions since it is common for them to be used interchangeably. If supporting the .yml extension is out of the question, this behavior should be documented.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

Additional context
I haven't confirmed, but this behavior may exist in the non-C# versions of the SDK as well.

@WretchedDade WretchedDade added the bug Something isn't working label Apr 1, 2025
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels Apr 1, 2025
@github-actions github-actions bot changed the title Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions .Net: Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions Apr 1, 2025
@github-actions github-actions bot changed the title .Net: Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions Python: Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions Apr 1, 2025
@WretchedDade WretchedDade changed the title Python: Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions Apr 1, 2025
@WretchedDade
Copy link
Author

WretchedDade commented Apr 1, 2025

Just checked. This behavior does not exist in the python implementation:

elif object.endswith(".yaml") or object.endswith(".yml"):

There, BOTH .yml and .yaml are supported. So, it looks like adding support for .yml would be the right path forward.

@WretchedDade WretchedDade linked a pull request Apr 1, 2025 that will close this issue
4 tasks
@markwallace-microsoft markwallace-microsoft self-assigned this Apr 3, 2025
@eavanvalkenburg eavanvalkenburg removed the python Pull requests for the Python Semantic Kernel label Apr 3, 2025
@markwallace-microsoft markwallace-microsoft moved this from Bug to Sprint: In Review in Semantic Kernel Apr 4, 2025
@markwallace-microsoft markwallace-microsoft moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
3 participants