Skip to content

fix(Windows): Support autolinking #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020
Merged

fix(Windows): Support autolinking #222

merged 1 commit into from
Sep 23, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 17, 2020

Resolves #219

Test Plan

  1. Bump react-native and react-native-windows to ^0.63
  2. Add a 0.63 compatible package with Windows support, e.g. react-native-camera
  3. Run yarn
  4. Run yarn install-windows-test-app
  5. Open windows/Example.sln
  6. Observe that AutolinkedNativeModules.g.cpp contains your package
  7. Build and run
diff --git a/example/package.json b/example/package.json
index d27ceb8..800f7fb 100644
--- a/example/package.json
+++ b/example/package.json
@@ -21,10 +21,10 @@
   "devDependencies": {
     "@babel/core": "^7.0.0",
     "mkdirp": "^0.5.1",
-    "react": "16.11.0",
-    "react-native": "0.62.2",
-    "react-native-macos": "0.62.10",
+    "react": "16.13.1",
+    "react-native": "0.63.2",
+    "react-native-camera": "^3.39.1",
     "react-native-test-app": "../",
-    "react-native-windows": "0.62.9"
+    "react-native-windows": "0.63.2"
   }
 }

@tido64 tido64 added the platform: Windows This affects Windows label Sep 17, 2020
@tido64 tido64 force-pushed the tido/rnw-autolink branch 6 times, most recently from 71c5a61 to 9846122 Compare September 18, 2020 06:21
@tido64 tido64 marked this pull request as ready for review September 19, 2020 19:54
@tido64 tido64 merged commit 7b9b9e7 into master Sep 23, 2020
@tido64 tido64 deleted the tido/rnw-autolink branch September 23, 2020 09:41
@tido64
Copy link
Member Author

tido64 commented Sep 23, 2020

🎉 This PR is included in version 0.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: Add support for autolinking
2 participants