Skip to content

Commit 1ae7692

Browse files
vgmahajanshettycsujedihy
authored andcommitted
Changes for issue 4856 (#4916)
* Changes for issue 4856 * Changes for issue 4856 * Changes for issue 4856
1 parent ce32fd3 commit 1ae7692

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,6 @@ jobs:
118118
- plat: android
119119
systemcrypto: '-UseSystemOpenSSLCrypto'
120120
# TODO: android to support ubuntu-24.04
121-
- plat: android
122-
os: 'ubuntu-24.04'
123-
systemcrypto: '-UseSystemOpenSSLCrypto'
124121
# No openssl system crypto on ubuntu-22.04
125122
- plat: linux
126123
os: 'ubuntu-22.04'

scripts/build.ps1

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,16 +505,21 @@ function CMake-Generate {
505505
$Arguments += " -DQUIC_HIGH_RES_TIMERS=on"
506506
}
507507
if ($Platform -eq "android") {
508-
$NDK = $env:ANDROID_NDK_LATEST_HOME -replace '26\.\d+\.\d+', '25.2.9519653' # Temporary work around. Use RegEx to replace newer version.
508+
$NDK = $env:ANDROID_NDK_LATEST_HOME
509509
$env:PATH = "$NDK/toolchains/llvm/prebuilt/linux-x86_64/bin:$env:PATH"
510+
$env:ANDROID_NDK_HOME = $NDK
511+
$env:ANDROID_NDK_ROOT = $NDK # Set ANDROID_NDK_ROOT to ensure consistency
512+
Write-Host "Set ANDROID_NDK_HOME: $env:ANDROID_NDK_HOME"
513+
Write-Host "Set ANDROID_NDK_ROOT: $env:ANDROID_NDK_ROOT"
514+
Write-Host "Set ANDROID_NDK_LATEST_HOME: $env:ANDROID_NDK_LATEST_HOME"
515+
510516
switch ($Arch) {
511517
"x86" { $Arguments += " -DANDROID_ABI=x86"}
512518
"x64" { $Arguments += " -DANDROID_ABI=x86_64" }
513519
"arm" { $Arguments += " -DANDROID_ABI=armeabi-v7a" }
514520
"arm64" { $Arguments += " -DANDROID_ABI=arm64-v8a" }
515521
}
516522
$Arguments += " -DANDROID_PLATFORM=android-29"
517-
$env:ANDROID_NDK_HOME = $NDK
518523
$NdkToolchainFile = "$NDK/build/cmake/android.toolchain.cmake"
519524
$Arguments += " -DANDROID_NDK=""$NDK"""
520525
$Arguments += " -DCMAKE_TOOLCHAIN_FILE=""$NdkToolchainFile"""

0 commit comments

Comments
 (0)