revert(react-utilities): undo using custom RefAttibute for getIntrinsicElementProps

Author: Hotell

packages/react-components/react-utilities/etc/react-utilities.api.md

@@ -72,7 +72,7 @@ export function getEventClientCoords(event: TouchOrMouseEvent): {
 };
 
 // @public
-export const getIntrinsicElementProps: <Props extends UnknownSlotProps, ExcludedPropKeys extends Extract<keyof Props, string> = never>(tagName: NonNullable<Props["as"]>, props: Props & RefAttributes<InferredElementRefType<Props>>, excludedPropNames?: ExcludedPropKeys[] | undefined) => DistributiveOmit<Props, ExcludedPropKeys | Exclude<keyof Props, "as" | keyof HTMLAttributes>>;
+export const getIntrinsicElementProps: <Props extends UnknownSlotProps, ExcludedPropKeys extends Extract<keyof Props, string> = never>(tagName: NonNullable<Props["as"]>, props: Props & React_2.RefAttributes<InferredElementRefType<Props>>, excludedPropNames?: ExcludedPropKeys[] | undefined) => DistributiveOmit<Props, ExcludedPropKeys | Exclude<keyof Props, "as" | keyof HTMLAttributes>>;
 
 // @public @deprecated
 export function getNativeElementProps<TAttributes extends React_2.HTMLAttributes<any>>(tagName: string, props: {}, excludedPropNames?: string[]): TAttributes;

packages/react-components/react-utilities/src/compose/getIntrinsicElementProps.ts

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import { getNativeElementProps } from '../utils/getNativeElementProps';
 import type { InferredElementRefType, UnknownSlotProps } from './types';
-import type { DistributiveOmit, RefAttributes } from '../utils/types';
+import type { DistributiveOmit } from '../utils/types';
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type HTMLAttributes = React.HTMLAttributes<any>;
@@ -11,16 +11,18 @@ type HTMLAttributes = React.HTMLAttributes<any>;
  * element type.
  *
  * Equivalent to {@link getNativeElementProps}, but more type-safe.
+ *
+ * @param tagName - The slot's default element type (e.g. 'div')
+ * @param props - The component's props object
+ * @param excludedPropNames - List of native props to exclude from the returned value
  */
 export const getIntrinsicElementProps = <
   Props extends UnknownSlotProps,
   ExcludedPropKeys extends Extract<keyof Props, string> = never,
 >(
-  /** The slot's default element type (e.g. 'div') */
   tagName: NonNullable<Props['as']>,
-  /** The component's props object */
-  props: Props & RefAttributes<InferredElementRefType<Props>>,
-  /** List of native props to exclude from the returned value */
+  // eslint-disable-next-line @typescript-eslint/no-restricted-types -- in order to not introduce Type Restriction CHANGe which is kinda "breaking change from Types POV", we don't enforce our custom `RefAttributes` in this API, to be compatible with scenarios where non v9 interfaces might be used. This may/will change with React 19
+  props: Props & React.RefAttributes<InferredElementRefType<Props>>,
   excludedPropNames?: ExcludedPropKeys[],
 ) => {
   // eslint-disable-next-line @typescript-eslint/no-deprecated