Skip to content

Commit 1edae31

Browse files
authored
pin FAST components dependency to facilitate upcoming breaking changes (#4672)
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. What problem does this change solve? Is this a breaking change, chore, fix, feature, etc? --> This change pins the dependency in `@microsoft/fast-tooling` and `@microsoft/fast-tooling-react` until `@microsoft/fast-components` completes it's breaking changes. Once these breaking changes in `@microsoft/fast-components` occur, work is planned for breaking changes in the tooling packages to update them to the new major version of `@microsoft/fast-components`. ## 👩‍💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. Do you recommend a smoke test for this PR? What steps should be followed? Are there particular areas of the code the reviewer should focus on? --> After doing a clean install, the `node_modules` in both the `packages/tooling/fast-tooilng` and `packages/tooling/fast-tooling-react` should have the pinned version instead of the symlinked version. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/Microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://www.fast.design/docs/community/code-of-conduct/#our-standards) for this project. ### Component-specific <!--- Review the list and put an x in the boxes that apply. --> <!--- Remove this section if not applicable. --> - [ ] I have added a new component - [ ] I have modified an existing component - [ ] I have updated the [definition file](https://github.com/Microsoft/fast/blob/master/packages/web-components/fast-components/CONTRIBUTING.md#definition) - [ ] I have updated the [configuration file](https://github.com/Microsoft/fast/blob/master/packages/web-components/fast-components/CONTRIBUTING.md#configuration) ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> After the work on the next major version of `@microsoft/fast-components` is complete, there will be a series of issues and PRs for updating the tooling to the new version.
1 parent d6a006b commit 1edae31

5 files changed

+27
-2
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "pin FAST components dependency to facilitate upcoming breaking changes",
4+
"packageName": "@microsoft/fast-tooling",
5+
"email": "[email protected]",
6+
"dependentChangeType": "none"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "pin FAST components dependency to facilitate upcoming breaking changes",
4+
"packageName": "@microsoft/fast-tooling-react",
5+
"email": "[email protected]",
6+
"dependentChangeType": "none"
7+
}

packages/tooling/fast-tooling-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
},
112112
"dependencies": {
113113
"@microsoft/fast-colors": "^5.1.3",
114-
"@microsoft/fast-components": "^1.20.6",
114+
"@microsoft/fast-components": "1.20.5",
115115
"@microsoft/fast-components-class-name-contracts-base": "^4.8.0",
116116
"@microsoft/fast-components-foundation-react": "^3.2.0",
117117
"@microsoft/fast-jss-manager-react": "^4.8.0",

packages/tooling/fast-tooling/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
"lodash-es": "^4.0.0"
9494
},
9595
"dependencies": {
96-
"@microsoft/fast-components": "^1.20.5",
96+
"@microsoft/fast-components": "1.20.5",
9797
"@microsoft/fast-foundation": "^1.20.0",
9898
"@microsoft/fast-web-utilities": "^4.7.3",
9999
"vscode-html-languageservice": "^3.1.3"

yarn.lock

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3054,6 +3054,17 @@
30543054
"@microsoft/fast-jss-utilities" "^4.8.0"
30553055
"@microsoft/fast-web-utilities" "^4.6.0"
30563056

3057+
"@microsoft/[email protected]":
3058+
version "1.20.5"
3059+
resolved "https://registry.yarnpkg.com/@microsoft/fast-components/-/fast-components-1.20.5.tgz#96b2010521b37937c966ca87b633730efa9cc731"
3060+
integrity sha512-JpOs55l1Vrgx3NOur354fdkmJSqDuSPr6cpq7Pfc1dfmsAlt8CTBerRivTr3d0wt0NNs6zm0zHC5C920gLPqvQ==
3061+
dependencies:
3062+
"@microsoft/fast-colors" "^5.1.3"
3063+
"@microsoft/fast-element" "^1.0.2"
3064+
"@microsoft/fast-foundation" "^1.20.0"
3065+
"@microsoft/fast-web-utilities" "^4.7.3"
3066+
tslib "^1.13.0"
3067+
30573068
"@microsoft/fast-jss-manager-react@^4.8.0":
30583069
version "4.8.0"
30593070
resolved "https://registry.yarnpkg.com/@microsoft/fast-jss-manager-react/-/fast-jss-manager-react-4.8.0.tgz#0694b18e9250a26a443ad0d6ab5938bbca2147ca"

0 commit comments

Comments
 (0)