clarify eof behavior for readMemory (#353)

connor4312 · web-flow · commit 00c1d789a9b2 · 2022-11-21T22:41:27.000-05:00
* clarify eof behavior for readMemory

* fix nit
diff --git a/changelog.md b/changelog.md
@@ -8,6 +8,7 @@ sectionid: changelog
 
 * 1.59.x:
   * Clarify the lifetime of `variablesReference`.
+  * Clarify end of file behavior for `readMemory`.
 
 * 1.58.x:
   * Specify the measurement unit of various `column` and "character positions" properties to be "UTF-16 code units".
diff --git a/debugAdapterProtocol.json b/debugAdapterProtocol.json
@@ -2912,7 +2912,7 @@
 							},
 							"data": {
 								"type": "string",
-								"description": "The bytes read from memory, encoded using base64."
+								"description": "The bytes read from memory, encoded using base64. If the decoded length of `data` is less than the requested `count` in the original `readMemory` request, and `unreadableBytes` is zero or omitted, then the client should assume it's reached the end of readable memory."
 							}
 						},
 						"required": [ "address" ]

Original file line number	Diff line number	Diff line change
`@@ -2912,7 +2912,7 @@`
`2912`	`2912`	`},`
`2913`	`2913`	`"data": {`
`2914`	`2914`	`"type": "string",`
`2915`		`- "description": "The bytes read from memory, encoded using base64."`
	`2915`	+ "description": "The bytes read from memory, encoded using base64. If the decoded length of `data` is less than the requested `count` in the original `readMemory` request, and `unreadableBytes` is zero or omitted, then the client should assume it's reached the end of readable memory."
`2916`	`2916`	`}`
`2917`	`2917`	`},`
`2918`	`2918`	`"required": [ "address" ]`