Skip to content

Commit 5b42222

Browse files
authored
Add upper bound for parse-duration package version (#97)
NPM package [parse-duration](https://www.npmjs.com/package/parse-duration) version was bumped from `1.1.0` to `2.1.3` In PR #95 for CodePush CLI. This caused the build to fail with the following error: ```shell % npm run build > [email protected] build > tsc script/command-parser.ts:1321:21 - error TS2349: This expression is not callable. Type 'typeof import("/private/tmp/ms-code-push-server/cli/node_modules/parse-duration/index")' has no call signatures. 1321 return Math.floor(parseDuration(durationString)); ~~~~~~~~~~~~~ Found 1 error in script/command-parser.ts:1321 ``` As current code-base is not compatible with `parse-duration` versions `2.0.0+`, restrict `parse-duration` to use version `1.x.y`.
1 parent b4f6dc1 commit 5b42222

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

cli/package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"jsonwebtoken": "^9.0.2",
2828
"moment": "^2.29.4",
2929
"opener": "^1.5.2",
30-
"parse-duration": "2.1.3",
30+
"parse-duration": "^1.1.0",
3131
"plist": "^3.0.6",
3232
"progress": "^2.0.3",
3333
"prompt": "^1.3.0",

0 commit comments

Comments
 (0)