Skip to content

Commit 2b294c8

Browse files
hanzhang54hanzhang54
authored
Set /W4 and treat warnings as errors (#2279)
1 parent 09a39a5 commit 2b294c8

File tree

16 files changed

+158
-97
lines changed

16 files changed

+158
-97
lines changed

‎src/CalcManager/CalcManager.vcxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
<PrecompiledHeader>Use</PrecompiledHeader>
142142
<CompileAsWinRT>false</CompileAsWinRT>
143143
<SDLCheck>true</SDLCheck>
144-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
144+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
145145
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
146146
<WarningLevel>Level4</WarningLevel>
147147
<TreatWarningAsError>true</TreatWarningAsError>
@@ -158,7 +158,7 @@
158158
<PrecompiledHeader>Use</PrecompiledHeader>
159159
<CompileAsWinRT>false</CompileAsWinRT>
160160
<SDLCheck>true</SDLCheck>
161-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
161+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
162162
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
163163
<WarningLevel>Level4</WarningLevel>
164164
<TreatWarningAsError>true</TreatWarningAsError>
@@ -176,7 +176,7 @@
176176
<PrecompiledHeader>Use</PrecompiledHeader>
177177
<CompileAsWinRT>false</CompileAsWinRT>
178178
<SDLCheck>true</SDLCheck>
179-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
179+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
180180
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
181181
<WarningLevel>Level4</WarningLevel>
182182
<TreatWarningAsError>true</TreatWarningAsError>
@@ -193,7 +193,7 @@
193193
<PrecompiledHeader>Use</PrecompiledHeader>
194194
<CompileAsWinRT>false</CompileAsWinRT>
195195
<SDLCheck>true</SDLCheck>
196-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
196+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
197197
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
198198
<WarningLevel>Level4</WarningLevel>
199199
<TreatWarningAsError>true</TreatWarningAsError>
@@ -211,7 +211,7 @@
211211
<PrecompiledHeader>Use</PrecompiledHeader>
212212
<CompileAsWinRT>false</CompileAsWinRT>
213213
<SDLCheck>true</SDLCheck>
214-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
214+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
215215
<PreprocessorDefinitions>_UNICODE;UNICODE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
216216
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
217217
<WarningLevel>Level4</WarningLevel>
@@ -229,7 +229,7 @@
229229
<PrecompiledHeader>Use</PrecompiledHeader>
230230
<CompileAsWinRT>false</CompileAsWinRT>
231231
<SDLCheck>true</SDLCheck>
232-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
232+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
233233
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
234234
<WarningLevel>Level4</WarningLevel>
235235
<TreatWarningAsError>true</TreatWarningAsError>
@@ -247,7 +247,7 @@
247247
<PrecompiledHeader>Use</PrecompiledHeader>
248248
<CompileAsWinRT>false</CompileAsWinRT>
249249
<SDLCheck>true</SDLCheck>
250-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
250+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
251251
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
252252
<WarningLevel>Level4</WarningLevel>
253253
<TreatWarningAsError>true</TreatWarningAsError>
@@ -264,7 +264,7 @@
264264
<PrecompiledHeader>Use</PrecompiledHeader>
265265
<CompileAsWinRT>false</CompileAsWinRT>
266266
<SDLCheck>true</SDLCheck>
267-
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 %(AdditionalOptions)</AdditionalOptions>
267+
<AdditionalOptions>/Zm250 /await /std:c++17 /permissive- /Zc:twoPhase- /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
268268
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
269269
<WarningLevel>Level4</WarningLevel>
270270
<TreatWarningAsError>true</TreatWarningAsError>

‎src/CalcViewModel/CalcViewModel.vcxproj

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,11 @@
154154
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
155155
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
156156
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
157-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
157+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
158158
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
159159
<LanguageStandard>stdcpp17</LanguageStandard>
160+
<WarningLevel>Level4</WarningLevel>
161+
<TreatWarningAsError>true</TreatWarningAsError>
160162
</ClCompile>
161163
<Link>
162164
<SubSystem>Console</SubSystem>
@@ -171,10 +173,12 @@
171173
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
172174
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
173175
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
174-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
176+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
175177
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
176178
<LanguageStandard>stdcpp17</LanguageStandard>
177179
<ControlFlowGuard>Guard</ControlFlowGuard>
180+
<WarningLevel>Level4</WarningLevel>
181+
<TreatWarningAsError>true</TreatWarningAsError>
178182
</ClCompile>
179183
<Link>
180184
<SubSystem>Console</SubSystem>
@@ -189,9 +193,11 @@
189193
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
190194
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
191195
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
192-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
196+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
193197
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
194198
<LanguageStandard>stdcpp17</LanguageStandard>
199+
<WarningLevel>Level4</WarningLevel>
200+
<TreatWarningAsError>true</TreatWarningAsError>
195201
</ClCompile>
196202
<Link>
197203
<SubSystem>Console</SubSystem>
@@ -206,10 +212,12 @@
206212
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
207213
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
208214
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
209-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
215+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
210216
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
211217
<LanguageStandard>stdcpp17</LanguageStandard>
212218
<ControlFlowGuard>Guard</ControlFlowGuard>
219+
<WarningLevel>Level4</WarningLevel>
220+
<TreatWarningAsError>true</TreatWarningAsError>
213221
</ClCompile>
214222
<Link>
215223
<SubSystem>Console</SubSystem>
@@ -224,9 +232,11 @@
224232
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
225233
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
226234
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
227-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
235+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
228236
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
229237
<LanguageStandard>stdcpp17</LanguageStandard>
238+
<WarningLevel>Level4</WarningLevel>
239+
<TreatWarningAsError>true</TreatWarningAsError>
230240
</ClCompile>
231241
<Link>
232242
<SubSystem>Console</SubSystem>
@@ -241,10 +251,12 @@
241251
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
242252
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
243253
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
244-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
254+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
245255
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
246256
<LanguageStandard>stdcpp17</LanguageStandard>
247257
<ControlFlowGuard>Guard</ControlFlowGuard>
258+
<WarningLevel>Level4</WarningLevel>
259+
<TreatWarningAsError>true</TreatWarningAsError>
248260
</ClCompile>
249261
<Link>
250262
<SubSystem>Console</SubSystem>
@@ -259,9 +271,11 @@
259271
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
260272
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
261273
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
262-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
274+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
263275
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
264276
<LanguageStandard>stdcpp17</LanguageStandard>
277+
<WarningLevel>Level4</WarningLevel>
278+
<TreatWarningAsError>true</TreatWarningAsError>
265279
</ClCompile>
266280
<Link>
267281
<SubSystem>Console</SubSystem>
@@ -276,10 +290,12 @@
276290
<PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
277291
<AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
278292
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
279-
<AdditionalOptions>/bigobj /await %(AdditionalOptions)</AdditionalOptions>
293+
<AdditionalOptions>/bigobj /await /w44242 %(AdditionalOptions)</AdditionalOptions>
280294
<DisableSpecificWarnings>28204;4453</DisableSpecificWarnings>
281295
<LanguageStandard>stdcpp17</LanguageStandard>
282296
<ControlFlowGuard>Guard</ControlFlowGuard>
297+
<WarningLevel>Level4</WarningLevel>
298+
<TreatWarningAsError>true</TreatWarningAsError>
283299
</ClCompile>
284300
<Link>
285301
<SubSystem>Console</SubSystem>

‎src/CalcViewModelCopyForUT/CalcViewModelCopyForUT.vcxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
<SDLCheck>true</SDLCheck>
134134
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
135135
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
136-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
136+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
137137
<WarningLevel>Level4</WarningLevel>
138138
<TreatWarningAsError>true</TreatWarningAsError>
139139
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -154,7 +154,7 @@
154154
<SDLCheck>true</SDLCheck>
155155
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
156156
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
157-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
157+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
158158
<WarningLevel>Level4</WarningLevel>
159159
<TreatWarningAsError>true</TreatWarningAsError>
160160
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -175,7 +175,7 @@
175175
<SDLCheck>true</SDLCheck>
176176
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
177177
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
178-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
178+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
179179
<WarningLevel>Level4</WarningLevel>
180180
<TreatWarningAsError>true</TreatWarningAsError>
181181
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -196,7 +196,7 @@
196196
<SDLCheck>true</SDLCheck>
197197
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
198198
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
199-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
199+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
200200
<WarningLevel>Level4</WarningLevel>
201201
<TreatWarningAsError>true</TreatWarningAsError>
202202
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -217,7 +217,7 @@
217217
<SDLCheck>true</SDLCheck>
218218
<AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
219219
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
220-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
220+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
221221
<WarningLevel>Level4</WarningLevel>
222222
<TreatWarningAsError>true</TreatWarningAsError>
223223
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -238,7 +238,7 @@
238238
<SDLCheck>true</SDLCheck>
239239
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
240240
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
241-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
241+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
242242
<WarningLevel>Level4</WarningLevel>
243243
<TreatWarningAsError>true</TreatWarningAsError>
244244
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -259,7 +259,7 @@
259259
<SDLCheck>true</SDLCheck>
260260
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
261261
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
262-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
262+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
263263
<WarningLevel>Level4</WarningLevel>
264264
<TreatWarningAsError>true</TreatWarningAsError>
265265
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -280,7 +280,7 @@
280280
<SDLCheck>true</SDLCheck>
281281
<AdditionalIncludeDirectories>$(SolutionDir)..\src\;$(SolutionDir)CalcViewModel\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
282282
<DisableSpecificWarnings>4453</DisableSpecificWarnings>
283-
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 %(AdditionalOptions)</AdditionalOptions>
283+
<AdditionalOptions>/bigobj /await /std:c++17 /utf-8 /w44242 %(AdditionalOptions)</AdditionalOptions>
284284
<WarningLevel>Level4</WarningLevel>
285285
<TreatWarningAsError>true</TreatWarningAsError>
286286
<PreprocessorDefinitions>VIEWMODEL_FOR_UT;%(PreprocessorDefinitions)</PreprocessorDefinitions>

0 commit comments

Comments
 (0)