Skip to content

Reproducing ECG5000 with min-max scaler #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WooheonHong opened this issue Mar 14, 2021 · 7 comments
Open

Reproducing ECG5000 with min-max scaler #10

WooheonHong opened this issue Mar 14, 2021 · 7 comments

Comments

@WooheonHong
Copy link

WooheonHong commented Mar 14, 2021

Hi,

I have been trying to reproduce your results and particularly those on the ECG dataset
Using the mix-max scaler with the norm_method causes the following errors:

python main.py --dataset ECG_data --norm_method min_max
File "main.py", line 61, in <module>
    _, normalize_statistic = train(train_data, valid_data, args, result_train_file)
File "handler.py", line 169, in train
    json.dump(normalize_statistic, f)

TypeError: Object of type ndarray is not JSON serializable

How can we solve this?

And could you tell me the parameters for reproducing metr-la dataset?
There is too much difference from the performance stated in the paper.

Thank you.

@WooheonHong WooheonHong changed the title min-max scaler error Reproducing ECG with min-max scaler Mar 14, 2021
@WooheonHong WooheonHong changed the title Reproducing ECG with min-max scaler Reproducing ECG5000 with min-max scaler Mar 14, 2021
@hangzhao-microsoft
Copy link
Contributor

hangzhao-microsoft commented Mar 15, 2021

Hi,

Thanks for your feedback, we have fixed this bug and we recommend you to use z-score for reproducing.

@razvanc92
Copy link

razvanc92 commented May 10, 2021

I ran the code with the default settings on ECG5000 (the provided data), and I get the following results: MAPE: 0.89 | MAE: 0.31 | RMSE: 0.5171 which are significantly worse when what is presented in the paper. Any suggestions on what could be the reason?

@WooheonHong
Copy link
Author

The code was different from the paper, so I reproduced it like a paper, but I also got extremely poor performance.
Has anyone succeeded in reproducing it?

@wangyuhu
Copy link

I also found this problem. I ran other model on ECG5000, also got poor performance: MAE: 0.34 | RMSE: 0.58.
Could the author teach us, pls?

@mb-Ma
Copy link

mb-Ma commented May 21, 2023

I ran the code with the default settings on ECG5000 (the provided data), and I get the following results: MAPE: 0.89 | MAE: 0.31 | RMSE: 0.5171 which are significantly worse when what is presented in the paper. Any suggestions on what could be the reason?

I also find this issue. Do you solve it? Or do you get any responses from the authors?

@Jimmy-Liu-JL
Copy link

I ran the code with the default settings on ECG5000 (the provided data), and I get the following results: MAPE: 0.89 | MAE: 0.31 | RMSE: 0.5171 which are significantly worse when what is presented in the paper. Any suggestions on what could be the reason?

I also find this issue. Do you solve it? Or do you get any responses from the authors?

I got this promblem, too.

@Man-Yacan
Copy link

Me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants