Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run][Plugin Manager] Translation of additional options #9929

Closed
htcfreek opened this issue Feb 26, 2021 · 4 comments
Closed

[Run][Plugin Manager] Translation of additional options #9929

htcfreek opened this issue Feb 26, 2021 · 4 comments
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Issue-Translation There is a problem with a translation Planning-Consideration Consideration for 2021 stability release Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager

Comments

@htcfreek
Copy link
Collaborator

We have now implemented a plugin management for PT Run into the settings ux. (PR #9872; Issue #5273)

The additional options and plugin list is saved in PT Run's settings file.
We save the names of the additional plugin option check boxes in the settings json ("C:\Users\Heiko\AppData\Local\Microsoft\PowerToys\PowerToys Run\settings.json").

@mykhailopylyp
How does translation works on this labels? Do we rewrite the file with the new names on relaunch of PT Run?

@htcfreek htcfreek added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Area-User Interface things that regard UX for PowerToys Issue-Translation There is a problem with a translation Product-Settings The standalone PowerToys Settings application Run-Plugin Manager Issues with the PowerToys Run plugin manager labels Feb 26, 2021
@enricogior enricogior removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Feb 26, 2021
@mykhailopylyp
Copy link
Contributor

If the English version was written to the settings.json file and a user switched to another language we will still use old labels.

At first, because plugins should provide those settings there is no easy way to handle it. Second, it looks like a very rare case.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 5, 2021

Can we use the same feature/behavior as in #10064 to update the translation of optional settings on language change?

Or can we use an identifier in settings.json to identify the string in the resources list.

@enricogior enricogior added the Planning-Consideration Consideration for 2021 stability release label Mar 8, 2021
@davidegiacometti davidegiacometti added the Status-In progress This issue or work-item is under development label Sep 3, 2021
@htcfreek
Copy link
Collaborator Author

htcfreek commented Sep 7, 2021

needs label fix

@davidegiacometti davidegiacometti added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Sep 7, 2021
@htcfreek
Copy link
Collaborator Author

htcfreek commented Oct 1, 2021

This was released with 0.47.0!

@htcfreek htcfreek closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Issue-Translation There is a problem with a translation Planning-Consideration Consideration for 2021 stability release Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
None yet
Development

No branches or pull requests

4 participants