Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Run][Plugin Manager] UI: Plugin icons not change on theme change #9913

Closed
htcfreek opened this issue Feb 26, 2021 · 5 comments
Closed

[Run][Plugin Manager] UI: Plugin icons not change on theme change #9913

htcfreek opened this issue Feb 26, 2021 · 5 comments
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. Run-Plugin Manager Issues with the PowerToys Run plugin manager

Comments

@htcfreek
Copy link
Collaborator

We have now implemented a plugin management for PT Run into the settings ux. (PR #9872; Issue #5273)

Bug:
Plugin icons do not change on windows theme change without rendering the whole page again.

This is a remaining work item form issue #9653.
@htcfreek htcfreek added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Run-Plugin Manager Issues with the PowerToys Run plugin manager Area-User Interface things that regard UX for PowerToys Product-Settings The standalone PowerToys Settings application labels Feb 26, 2021
@enricogior enricogior removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Feb 26, 2021
@htcfreek
Copy link
Collaborator Author

htcfreek commented Apr 4, 2021

@enricogior , @mykhailopylyp
Any plans when to implement this?

@htcfreek
Copy link
Collaborator Author

@niels9001
Is it by design that this bug exists in the new Settings UX (#12470) too?

@niels9001
Copy link
Contributor

@htcfreek Not really straight forward solution. The images are .pngs so it should require to reload them. So it's a bug, but low priority imo.

@htcfreek
Copy link
Collaborator Author

@htcfreek Not really straight forward solution. The images are .pngs so it should require to reload them. So it's a bug, but low priority imo.

I only want to know if this is a bug in our code or in theory should be fixed in WinUI 2.6. But I may have asked in a bad way.

@cinnamon-msft
Copy link
Collaborator

Looks like this has been fixed, going to close! :)

@cinnamon-msft cinnamon-msft added the Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
2. Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@enricogior @niels9001 @cinnamon-msft @htcfreek