Skip to content

[Run Plugin manager] Allow multiple authors #13079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
htcfreek opened this issue Sep 6, 2021 · 7 comments
Closed

[Run Plugin manager] Allow multiple authors #13079

htcfreek opened this issue Sep 6, 2021 · 7 comments
Labels
Area-User Interface things that regard UX for PowerToys Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Run-Plugin Manager Issues with the PowerToys Run plugin manager Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Sep 6, 2021

We should think about to allow more than one plugin author in plugin.json and to show it as comma separated list in the plugin manager ux. I suggest to allow this because sometimes other contributors than the original plugin author are adding improvements and features.

Additional it should be possible to assign different homepage urls per author. (In addition to the plugin web page itself.) This allows an author to link to it's GitHub page. (This touches #9921.)

Original comment

How de we handle cases like this where an other contributor than the original plugin author adds some improvements? Should I simply add my name to the authors property of plugin.json? Or do we ignore this. (I personally would prefer the option to mention more than one author in plugin.json with the possibility to add different homepages per author. But this needs to be a separate issue.)
Originally posted by @htcfreek in #12915 (comment)

@htcfreek htcfreek added Area-User Interface things that regard UX for PowerToys Run-Plugin Things that relate with PowerToys Run's plugin interface Run-Plugin Manager Issues with the PowerToys Run plugin manager Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Idea-Enhancement New feature or request on an existing product labels Sep 6, 2021
@htcfreek
Copy link
Collaborator Author

htcfreek commented Sep 15, 2021

Hi @htcfreek,
I've just verified and the author field is for the original author of the plugin. (...)

Originally posted by @jaimecbernardo in #13151 (comment)

@htcfreek
Copy link
Collaborator Author

htcfreek commented Sep 15, 2021

@jaimecbernardo, @crutkas
Should we close this issue or discuss about other possible solutions like an "Improvements made by" field?

@jaimecbernardo
Copy link
Collaborator

I feel like the discussion can live in this issue, which is how to attribute significant contributions to plugins.

@htcfreek
Copy link
Collaborator Author

@niels9001
Because this will have a ux part too I like to have you been part of the discussion.

@niels9001
Copy link
Contributor

What about a simple fix by just changing the Authored by into "Contribrutors" and name the people in the plugin.json string? E.g. "Jane, John and Joe"?

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Dec 20, 2021
@crutkas
Copy link
Member

crutkas commented Dec 20, 2021

I'm with @niels9001 solution on this. don't over engineer

@crutkas crutkas added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Dec 20, 2021
@htcfreek
Copy link
Collaborator Author

@crutkas , @niels9001
Can I close this. We had no case in the past where this feature was needed. So I don't see any reason to implement it.

@htcfreek htcfreek closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Run-Plugin Manager Issues with the PowerToys Run plugin manager Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
Status: ✅Done
Development

No branches or pull requests

4 participants