Skip to content

v2 - implement tests for routing issues #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
baywet opened this issue Jan 22, 2025 · 1 comment · May be fixed by #2340
Open

v2 - implement tests for routing issues #2081

baywet opened this issue Jan 22, 2025 · 1 comment · May be fixed by #2340
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience
Milestone
v2-Preview18

Comments

@baywet
Copy link
Member

baywet commented Jan 22, 2025

In #2041 and #2042 I've fixed issues where due to the layering of the serialization code, a V2 serialization method ended up calling a v3 serialization method when it shouldn't have.

We should implement use tests controlling for that with spies where we effectively:

  • spy all v3 methods for objects that have a v2 serialization method
  • populate a large DOM, trying to cover all API surface
  • run v2 serialization
  • control that no v3/3.1 method has been called

We should probably implement the other way around (v3 doesn't call v2) and deserialization tests as well
@baywet baywet added priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience labels Jan 22, 2025
@baywet baywet added this to the v2 - Preview10 milestone Feb 19, 2025
@RachitMalik12
Copy link
Contributor

@baywet

  1. What do you mean by spy?

@MaggieKimani1 MaggieKimani1 linked a pull request Apr 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience
Projects
None yet
Milestone
v2-Preview18
Development

Successfully merging a pull request may close this issue.

chore: implement tests for routing issues during serialization microsoft/OpenAPI.NET
2 participants
@baywet @RachitMalik12