Skip to content

Commit d0e995f

Browse files
committed
reduce duplicated paths in docs
1 parent 369da1f commit d0e995f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

R-package/README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,7 @@ After installing `Rtools` and `CMake`, be sure the following paths are added to
3535
* `R`
3636
- example: `C:\Program Files\R\R-3.6.1\bin`
3737

38-
As of `Rtools` 4.0, some common paths changed and software was removed from `Rtools`. If you are using `R` 4.0 or later and the corresponding `Rtools`, you need to add one additional path to `PATH`.
39-
40-
* `Rtools` usr bin:
41-
- example: `C:\Rtools\usr\bin`
38+
NOTE: Two `Rtools` paths are required from `Rtools` 4.0 onwards because paths and the list of included software was changed in `Rtools` 4.0.
4239

4340
#### Windows Toolchain Options
4441

R-package/inst/make-r-def.R

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,12 @@ message(sprintf("Creating '%s' from '%s'", OUT_DEF_FILE, IN_DLL_FILE))
4141
, "'processx' with install.packages('processx') might "
4242
, "make this faster."
4343
))
44+
# shQuote() is necessary here since one of the arguments
45+
# is a file-path to R.dll, which may have spaces. processx
46+
# does such quoting but system2() does not
4447
exit_code <- system2(
4548
command = command
46-
, args = args
49+
, args = shoQuote(args)
4750
, stdout = out_file
4851
)
4952
if (exit_code != 0L) {

0 commit comments

Comments
 (0)