Skip to content

Commit 36813b7

Browse files
committed
getting better logs
1 parent 7bb6baf commit 36813b7

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.ci/test_r_package_windows.ps1

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ Write-Output "Installing dependencies"
8686
$packages = "c('data.table', 'jsonlite', 'Matrix', 'processx', 'R6', 'testthat'), dependencies = c('Imports', 'Depends', 'LinkingTo')"
8787
Rscript --vanilla -e "options(install.packages.check.source = 'no'); install.packages($packages, repos = '$env:CRAN_MIRROR', type = 'binary', lib = '$env:R_LIB_PATH')" ; Check-Output $?
8888

89+
Rscript build_r.R
90+
Check-Output $false
91+
8992
Write-Output "Building R package"
9093

9194
# R CMD check is not used for MSVC builds

R-package/inst/make-r-def.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ IN_DLL_FILE <- args[[1L]]
1414
OUT_DEF_FILE <- args[[2L]]
1515
DLL_BASE_NAME <- basename(IN_DLL_FILE)
1616

17-
print(sprintf("Creating '%s' from '%s'", OUT_DEF_FILE, IN_DLL_FILE))
17+
message(sprintf("Creating '%s' from '%s'", OUT_DEF_FILE, IN_DLL_FILE))
1818

1919
# use objdump to dump all the symbols
2020
OBJDUMP_FILE <- "objdump-out.txt"
@@ -58,3 +58,4 @@ writeLines(
5858
, con = OUT_DEF_FILE
5959
, sep = "\n"
6060
)
61+
message(sprintf("Successfully created '%s'", OUT_DEF_FILE))

R-package/src/install.libs.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ if (!use_precompile) {
157157
# Must build twice for Windows due sh.exe in Rtools
158158
cmake_args <- c(cmake_args, "-G", shQuote("MinGW Makefiles"))
159159
.run_shell_command("cmake", c(cmake_args, ".."), strict = FALSE)
160-
build_cmd <- "make.exe"
160+
build_cmd <- "make"
161161
build_args <- "_lightgbm"
162162
} else {
163163
visual_studio_succeeded <- .generate_vs_makefiles(cmake_args)
@@ -166,7 +166,7 @@ if (!use_precompile) {
166166
# Must build twice for Windows due sh.exe in Rtools
167167
cmake_args <- c(cmake_args, "-G", shQuote("MinGW Makefiles"))
168168
.run_shell_command("cmake", c(cmake_args, ".."), strict = FALSE)
169-
build_cmd <- "make.exe"
169+
build_cmd <- "make"
170170
build_args <- "_lightgbm"
171171
} else {
172172
build_cmd <- "cmake"

0 commit comments

Comments
 (0)