Skip to content

Some CertificateObjects get created with null store locations #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guyacosta opened this issue Apr 5, 2019 · 2 comments · Fixed by #116
Closed

Some CertificateObjects get created with null store locations #80

guyacosta opened this issue Apr 5, 2019 · 2 comments · Fixed by #116
Assignees
Labels
bug Something isn't working

Comments

@guyacosta
Copy link
Contributor

ExceptionOnTelmetryPost
Describe the bug
Detected an exception being reported regularly for GUI version of app related to inability to write to certificate table.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Scan, run a couple
  2. Click on Results to analyze
  3. Note captured exception being sent as part of telemetry

Expected behavior
No exceptions reported on normal application use

Screenshots
If applicable, add screenshots to help explain your problem.

System Configuration (please complete the following information):

  • OS: [e.g. Windows]
  • OS Version: [e.g. Windows 10 1803]
  • Application Version: [e.g. 2.0.1-beta+50af283871]
  • CLI or GUI:

Additional Context
Add any other context about the problem here.
ExceptionOnTelmetryPost

@guyacosta guyacosta added the bug Something isn't working label Apr 5, 2019
@gfs gfs changed the title Cannot read property StoreLocation of null Some CertificateObjects get created with null store locations Apr 6, 2019
@gfs
Copy link
Contributor

gfs commented Apr 6, 2019

Should investigate why this is happening. The underlying code is deserializing a CertificateObject, which otherwise should be working fine, so it likely means that either a certificate object was created with a null StoreLocation field, or somehow there's a ghost null result when there are otherwise no results.

@gfs gfs added this to the Initial Public Release milestone Apr 12, 2019
@gfs gfs closed this as completed Apr 17, 2019
@gfs
Copy link
Contributor

gfs commented Apr 17, 2019

Fixed in #116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants