Skip to content

Commit ca7ec02

Browse files
authored
Gfs/fix compare command null (#115)
* Adds exception handling to certificate result parsing. * Fixes CertificateCompare crash when comparing removed certs
1 parent a0500ba commit ca7ec02

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Lib/Collectors/Certificates/CertificateCompare.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public override void Compare(string firstRunId, string secondRunId)
7070

7171
Log.Information("{0} {1} {2}",Strings.Get("Found"), addObjects.Count, Strings.Get("Created"));
7272

73-
var removeObjects = new List<string>();
73+
var removeObjects = new List<CertificateResult>();
7474
cmd = new SqliteCommand(SELECT_DELETED_SQL, DatabaseManager.Connection, DatabaseManager.Transaction);
7575
cmd.Parameters.AddWithValue("@first_run_id", firstRunId);
7676
cmd.Parameters.AddWithValue("@second_run_id", secondRunId);
@@ -93,7 +93,7 @@ public override void Compare(string firstRunId, string secondRunId)
9393
ChangeType = CHANGE_TYPE.DELETED,
9494
ResultType = RESULT_TYPE.CERTIFICATE
9595
};
96-
addObjects.Add(obj);
96+
removeObjects.Add(obj);
9797
InsertResult(obj);
9898
}
9999
}

0 commit comments

Comments
 (0)