Review

Author: alexandear

RULES_DESCRIPTIONS.md

@@ -508,9 +508,9 @@ _Description_: This rule enforces a maximum number of lines per file, in order t
 
 _Configuration_:
 
-* `max` (int) a maximum number of lines in a file (default 1000)
-* `skipComments` (bool) ignore lines containing just comments
-* `skipBlankLines` (bool) ignore lines made up purely of whitespace
+* `max` (int) a maximum number of lines in a file (default `1000`)
+* `skipComments` (bool) if true ignore and do not count lines containing just comments (default `false`)
+* `skipBlankLines` (bool) if true ignore and do not count lines made up purely of whitespace (default `false`)
 
 Example:
 

rule/file-length-limit.go

@@ -31,7 +31,7 @@ func (r *FileLengthLimitRule) Apply(file *lint.File, arguments lint.Arguments) [
 	scanner := bufio.NewScanner(bytes.NewReader(file.Content()))
 	for scanner.Scan() {
 		all++
-		if len(scanner.Bytes()) == 0 {
+		if len(bytes.TrimSpace(scanner.Bytes())) == 0 {
 			blank++
 		}
 	}
@@ -113,6 +113,9 @@ func countCommentLines(comments []*ast.CommentGroup) int {
 	count := 0
 	for _, cg := range comments {
 		for _, comment := range cg.List {
+			if len(comment.Text) < 2 {
+				continue
+			}
 			switch comment.Text[1] {
 			case '/': // single-line comment
 				count++