fix: panic with getFieldTypeName (#1229)

* fix: panic with interface type and array

* replaces panic with a return of a default string

* review

---------

Co-authored-by: chavacava <[email protected]>

Author: ldez

internal/astutils/ast_utils.go

@@ -2,7 +2,6 @@
 package astutils
 
 import (
-	"fmt"
 	"go/ast"
 )
 
@@ -73,7 +72,11 @@ func getFieldTypeName(typ ast.Expr) string {
 		return "*" + getFieldTypeName(f.X)
 	case *ast.IndexExpr:
 		return getFieldTypeName(f.X) + "[" + getFieldTypeName(f.Index) + "]"
+	case *ast.ArrayType:
+		return "[]" + getFieldTypeName(f.Elt)
+	case *ast.InterfaceType:
+		return "interface{}"
 	default:
-		panic(fmt.Sprintf("not supported type %T", typ))
+		return "UNHANDLED_TYPE"
 	}
 }

testdata/golint/sort.go

@@ -44,3 +44,12 @@ func (x X) Less(i *pkg.tip) (result bool) { return len(x) } // MATCH /exported m
 
 // Test for issue #1217
 func (s *synchronized[T]) Swap(other Synchronized[T]) {}
+
+// Swap for issue #1228
+func (s *synchronized[T]) Swap(other interface{}) {}
+
+// Swap for issue #1228
+func (s *synchronized[T]) Swap(other []int) {}
+
+// Swap for issue #1228
+func (s *synchronized[T]) Swap(other []interface{}) {}