fixed some complex code (#580)

Author: sina-devel

lint/file.go

@@ -91,10 +91,7 @@ func (f *File) IsUntypedConst(expr ast.Expr) (defType string, ok bool) {
 }
 
 func (f *File) isMain() bool {
-	if f.AST.Name.Name == "main" {
-		return true
-	}
-	return false
+	return f.AST.Name.Name == "main"
 }
 
 const directiveSpecifyDisableReason = "specify-disable-reason"

rule/add-constant.go

@@ -82,7 +82,7 @@ func (r *AddConstantRule) Apply(file *lint.File, arguments lint.Arguments) []lin
 		failures = append(failures, failure)
 	}
 
-	w := lintAddConstantRule{onFailure: onFailure, strLits: make(map[string]int, 0), strLitLimit: strLitLimit, whiteLst: whiteList}
+	w := lintAddConstantRule{onFailure: onFailure, strLits: make(map[string]int), strLitLimit: strLitLimit, whiteLst: whiteList}
 
 	ast.Walk(w, file.AST)
 

rule/empty-block.go

@@ -17,7 +17,7 @@ func (r *EmptyBlockRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure
 		failures = append(failures, failure)
 	}
 
-	w := lintEmptyBlock{make(map[*ast.BlockStmt]bool, 0), onFailure}
+	w := lintEmptyBlock{make(map[*ast.BlockStmt]bool), onFailure}
 	ast.Walk(w, file.AST)
 	return failures
 }

rule/max-public-structs.go

@@ -63,7 +63,6 @@ func (w *lintMaxPublicStructs) Visit(n ast.Node) ast.Visitor {
 		if strings.ToUpper(first) == first {
 			w.current++
 		}
-		break
 	}
 	return w
 }