chore: address comments

Author: destifo

.ghjk/lock.json

@@ -1,6 +1,6 @@
 {
   "version": "0",
-  "platform": "x86_64-linux",
+  "platform": "aarch64-darwin",
   "moduleEntries": {
     "ports": {
       "version": "0",
@@ -434,7 +434,6 @@
             "dd83a99f49f3f0fba11cdd014ff718cc9539316b",
             "4d1916871a40b6ac730709f7721f740df192c84d",
             "4df902463d60efc5b8e760ea4899f6ab6df0f16e",
-            "88f6aa5ddb513712623d31a17096ea26286064da",
             "40d9babcd5c8e79379e58dbc2f2a967ef68fbb09",
             "5549508f1f5eddf9cb2465f07cf0c7603dc0c849",
             "5c041a4209ae50657ea5acacc26683688f2913a9",
@@ -849,25 +848,6 @@
           },
           "packageName": "node-gyp"
         },
-        "88f6aa5ddb513712623d31a17096ea26286064da": {
-          "version": "v2.4.0",
-          "port": {
-            "ty": "denoWorker@v1",
-            "name": "mold_ghrel",
-            "platforms": [
-              "aarch64-linux",
-              "x86_64-linux"
-            ],
-            "version": "0.1.0",
-            "deps": [
-              {
-                "name": "tar_aa"
-              }
-            ],
-            "moduleSpecifier": "https://raw.githubusercontent.com/metatypedev/ghjk/423d38e/ports/mold.ts"
-          },
-          "replaceLd": false
-        },
         "40d9babcd5c8e79379e58dbc2f2a967ef68fbb09": {
           "version": "3.8.18",
           "port": {

typegate/src/config.ts

@@ -42,6 +42,9 @@ const schema = {
   sentry_dsn: z.string().optional(),
   sentry_sample_rate: z.coerce.number().positive().min(0).max(1),
   sentry_traces_sample_rate: z.coerce.number().positive().min(0).max(1),
+  /**
+   * Time in seconds in which a URL expires after being pushed to Redis
+   */
   redis_url_queue_expire_sec: z.coerce.number().positive(),
 };
 

typegate/src/services/artifact_service.ts

@@ -24,7 +24,21 @@ export class ArtifactService {
           headers: { "Content-Type": "application/json" },
         });
       }
-      const metaList = getUploadUrlBodySchema.parse(await request.json());
+
+      let metaList;
+      try {
+        metaList = getUploadUrlBodySchema.parse(await request.json());
+      } catch (error) {
+        console.error("Failed to parse data:", error);
+        return new Response(
+          JSON.stringify({ error: `Invalid Request Body: ${error.message}` }),
+          {
+            status: 400,
+            headers: { "Content-Type": "application/json" },
+          },
+        );
+      }
+
       try {
         const data = await this.#createUploadUrls(
           metaList,

typegate/src/typegate/artifacts/local.ts

@@ -19,7 +19,12 @@ export interface UploadUrlStore {
   expirationTimerId: number;
 }
 
+/**
+ * Initialize Upload URLs store. The URL store holds the upload URLs used for persisiting artifacts. Each URL is mapped to the Artifact Meta to be uploaded. The store uses an Expiration Queue to keep track of expiration status of URLs and discards the URLs upon expiration.
+ * @returns URL to Artifact Meta map, URL expiration queue and expiration timer Id
+ */
 function initUploadUrlStore() {
+  // stores one to one mapping between upload URLs and
   const mapToMeta = new Map<string, ArtifactMeta>();
   const expirationQueue: [string, number][] = [];
   const expirationTimerId = setInterval(() => {

typegate/src/typegate/artifacts/shared.ts

@@ -52,11 +52,7 @@ function serializeToRedisValue<T>(value: T): string {
 }
 
 function deserializeToCustom<T>(value: string): T {
-  try {
-    return JSON.parse(value) as T;
-  } catch (error) {
-    throw error;
-  }
+  return JSON.parse(value) as T;
 }
 
 function resolveS3Key(hash: string) {

typegate/tests/utils/test.ts

@@ -112,6 +112,10 @@ export class MetaTest {
     this.cleanups.push(fn);
   }
 
+  get typegate() {
+    return this.typegates.next();
+  }
+
   getTypegraphEngine(name: string): QueryEngine | undefined {
     return this.typegates.next().register.get(name);
   }