fix: better error message for missing artifacts (#973)

<!--
Pull requests are squashed and merged using:
- their title as the commit message
- their description as the commit body

Having a good title and description is important for the users to get
readable changelog.
-->

<!-- 1. Explain WHAT the change is about -->

- Solve
[MET-821](https://linear.app/metatypedev/issue/MET-821/bad-error-message-on-missing-deno-rt-deps)
  - Better error message for missing artifacts
  - Shared logic for artifact registration on postprocess

<!-- 2. Explain WHY the change cannot be made simpler -->

-

<!-- 3. Explain HOW users should update their code -->

#### Migration notes

---

- [ ] The change comes with new or modified tests
- [ ] Hard-to-understand functions have explanatory comments
- [ ] End-user documentation is updated to reflect the change


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Consolidated the artifact registration process to support bulk
handling of primary and dependency artifacts.

- **Refactor**
- Streamlined registration workflows across multiple runtime
integrations, enhancing efficiency and clarity.

- **Tests**
- Added comprehensive tests to ensure robust error reporting when
dependencies are missing.
- Introduced a new test case to validate behavior for non-existent
engine scripts.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: Natoandro

deno.lock

@@ -9,11 +9,44 @@ use common::typegraph::{runtimes::Artifact, Typegraph};
 
 pub trait ArtifactsExt {
     /// update the artifact meta, and register the artifact in the typegraph
-    fn register_artifact(&self, artifact_path: PathBuf, tg: &mut Typegraph) -> Result<()>;
+    fn register_artifacts(
+        &self,
+        tg: &mut Typegraph,
+        entry: PathBuf,
+        deps: Vec<PathBuf>,
+    ) -> Result<Vec<PathBuf>>;
 }
 
 impl ArtifactsExt for FsContext {
-    fn register_artifact(&self, path: PathBuf, tg: &mut Typegraph) -> Result<()> {
+    fn register_artifacts(
+        &self,
+        tg: &mut Typegraph,
+        entry: PathBuf,
+        deps: Vec<PathBuf>,
+    ) -> Result<Vec<PathBuf>> {
+        let mut registered_deps = vec![];
+        self.register_artifact(tg, entry)?;
+        for dep in deps {
+            let artifacts = self.list_files(&[dep.to_string_lossy().to_string()]);
+            if artifacts.is_empty() {
+                return Err(format!(
+                    "no artifacts found for dependency '{}'",
+                    dep.to_string_lossy()
+                )
+                .into());
+            }
+            for artifact in artifacts.into_iter() {
+                self.register_artifact(tg, artifact.clone())?;
+                registered_deps.push(artifact);
+            }
+        }
+
+        Ok(registered_deps)
+    }
+}
+
+impl FsContext {
+    fn register_artifact(&self, tg: &mut Typegraph, path: PathBuf) -> Result<()> {
         use std::collections::btree_map::Entry;
         if let Entry::Vacant(entry) = tg.meta.artifacts.entry(path) {
             let path = entry.key().to_path_buf();

src/typegraph/core/src/utils/artifacts.rs

@@ -28,17 +28,9 @@ impl PostProcessor for DenoProcessor {
                 let mut mat_data: ModuleMatData =
                     object_from_map(mat_data).map_err(|e| e.to_string())?;
 
-                fs_ctx.register_artifact(mat_data.entry_point.clone(), tg)?;
-
+                let entry_point = mat_data.entry_point.clone();
                 let deps = std::mem::take(&mut mat_data.deps);
-                for artifact in deps.into_iter() {
-                    let artifacts = fs_ctx.list_files(&[artifact.to_string_lossy().to_string()]);
-                    for artifact in artifacts.iter() {
-                        fs_ctx.register_artifact(artifact.clone(), tg)?;
-                    }
-                    mat_data.deps.extend(artifacts);
-                }
-
+                mat_data.deps = fs_ctx.register_artifacts(tg, entry_point, deps)?;
                 mat.data = map_from_object(mat_data).map_err(|e| e.to_string())?;
             }
         }

src/typegraph/core/src/utils/postprocess/deno_rt.rs

@@ -30,17 +30,9 @@ impl PostProcessor for PythonProcessor {
                 let mut mat_data: ModuleMatData =
                     object_from_map(mat_data).map_err(|e| e.to_string())?;
 
-                fs_ctx.register_artifact(mat_data.entry_point.clone(), tg)?;
-
+                let entrypoint = mat_data.entry_point.clone();
                 let deps = std::mem::take(&mut mat_data.deps);
-                for artifact in deps.into_iter() {
-                    let artifacts = fs_ctx.list_files(&[artifact.to_string_lossy().to_string()]);
-                    for artifact in artifacts.iter() {
-                        fs_ctx.register_artifact(artifact.clone(), tg)?;
-                    }
-                    mat_data.deps.extend(artifacts);
-                }
-
+                mat_data.deps = fs_ctx.register_artifacts(tg, entrypoint, deps)?;
                 mat.data = map_from_object(mat_data).map_err(|e| e.to_string())?;
             }
         }

src/typegraph/core/src/utils/postprocess/python_rt.rs

@@ -21,22 +21,17 @@ impl SubstantialProcessor {
 impl PostProcessor for SubstantialProcessor {
     fn postprocess(self, tg: &mut Typegraph) -> Result<(), crate::errors::TgError> {
         let fs_ctx = FsContext::new(self.typegraph_dir.clone());
-        let runtimes = std::mem::take(&mut tg.runtimes);
+        let mut runtimes = std::mem::take(&mut tg.runtimes);
 
-        for runtime in runtimes.iter() {
+        for runtime in runtimes.iter_mut() {
             if let TGRuntime::Known(known_runtime) = runtime {
                 match known_runtime {
                     runtimes::KnownRuntime::Substantial(data) => {
-                        for wf_description in &data.workflows {
-                            fs_ctx.register_artifact(wf_description.file.clone(), tg)?;
-
-                            for artifact in &wf_description.deps {
-                                let artifacts: Vec<PathBuf> =
-                                    fs_ctx.list_files(&[artifact.to_string_lossy().to_string()]);
-                                for artifact in artifacts.iter() {
-                                    fs_ctx.register_artifact(artifact.clone(), tg)?;
-                                }
-                            }
+                        for wf_description in &mut data.workflows {
+                            let entrypoint = wf_description.file.clone();
+                            let deps = std::mem::take(&mut wf_description.deps);
+                            wf_description.deps =
+                                fs_ctx.register_artifacts(tg, entrypoint, deps)?;
                         }
                     }
                     _ => continue,

src/typegraph/core/src/utils/postprocess/substantial_rt.rs

@@ -34,7 +34,7 @@ impl PostProcessor for WasmProcessor {
                 }
             };
 
-            fs_ctx.register_artifact(data.wasm_artifact.clone(), tg)?;
+            fs_ctx.register_artifacts(tg, data.wasm_artifact.clone(), vec![])?;
         }
 
         tg.runtimes = runtimes;

src/typegraph/core/src/utils/postprocess/wasm_rt.rs

@@ -4,7 +4,12 @@
 import { Meta } from "test-utils/mod.ts";
 import { join } from "@std/path/join";
 import { exists } from "@std/fs/exists";
-import { assert, assertFalse } from "@std/assert";
+import {
+  assert,
+  assertFalse,
+  assertRejects,
+  assertStringIncludes,
+} from "@std/assert";
 import { connect } from "redis";
 import { S3Client } from "aws-sdk/client-s3";
 import { createBucket, hasObject, tryDeleteBucket } from "test-utils/s3.ts";
@@ -199,3 +204,19 @@ for (const { mode, ...options } of variants) {
     },
   );
 }
+
+Meta.test(`Missing artifact`, async (t) => {
+  await t.should("fail on missing artifact", async () => {
+    await assertRejects(
+      async () => {
+        await t.engine("runtimes/deno/inexisting_dep.py");
+      },
+    );
+    try {
+      await t.engine("runtimes/deno/inexisting_dep.py");
+      assert(false, "should have thrown");
+    } catch (e) {
+      assertStringIncludes(e.message, "no artifacts found for dependency");
+    }
+  });
+});

tests/artifacts/artifacts_test.ts

@@ -9,23 +9,23 @@
     "lint": "next lint"
   },
   "dependencies": {
-    "@apollo/client": "^3",
-    "apollo-upload-client": "^18",
-    "graphql": "^16",
-    "next": "^14",
-    "react": "^18",
-    "react-dom": "^18"
+    "@apollo/client": "^3.12.9",
+    "apollo-upload-client": "^18.0.1",
+    "graphql": "^16.10.0",
+    "next": "^14.2.23",
+    "react": "^18.3.1",
+    "react-dom": "^18.3.1"
   },
   "devDependencies": {
-    "@types/apollo-upload-client": "^17",
-    "@types/node": "^20",
-    "@types/react": "^18",
-    "@types/react-dom": "^18",
-    "autoprefixer": "^10",
-    "eslint": "^8",
-    "eslint-config-next": "14",
-    "postcss": "^8",
-    "tailwindcss": "^3",
-    "typescript": "^5"
+    "@types/apollo-upload-client": "^17.0.5",
+    "@types/node": "^20.17.17",
+    "@types/react": "^18.3.18",
+    "@types/react-dom": "^18.3.5",
+    "autoprefixer": "^10.4.20",
+    "eslint": "^8.57.1",
+    "eslint-config-next": "^14.2.23",
+    "postcss": "^8.5.1",
+    "tailwindcss": "^3.4.17",
+    "typescript": "^5.7.3"
   }
 }