MBS-11507: Remove useless resend-verification code

The whole resend-verification code was added in 2011 (MBS-3188)
apparently under the incorrect assumption that we store the email
a user has entered before it gets verified. In fact, we only store it
as part of the verification process - so there's no possible case
where we would have an email stored that still needs verifying.
The entirety of the resend-verification code is as such
completely useless, since there's no reason to re-verify
an already verified email address (even though that's what
the Reverify test was testing).

Author: reosarevok

lib/MusicBrainz/Server/Controller/Account.pm

@@ -621,23 +621,6 @@ sub register : Path('/register') ForbiddenOnMirrors RequireSSL DenyWhenReadonly
     );
 }
 
-=head2 resend_verification
-
-Send out an email allowing users to verify their email address, from the web
-
-=cut
-
-sub resend_verification : Path('/account/resend-verification') ForbiddenOnMirrors RequireAuth
-{
-    my ($self, $c) = @_;
-    my $editor = $c->model('Editor')->get_by_id($c->user->id);
-    if ($editor->has_email_address) {
-        $self->_send_confirmation_email($c, $editor, $editor->email);
-    }
-    $c->response->redirect($c->uri_for_action('/user/profile', [ $editor->name ]));
-    $c->detach;
-}
-
 =head2 _send_confirmation_email
 
 Send out an email allowing users to verify their email address

lib/MusicBrainz/Server/Controller/User.pm

@@ -300,8 +300,7 @@ sub _check_for_confirmed_email {
             component_path  => 'user/UserMessage',
             component_props => {
                 title    => l('Send Email'),
-                message  => l('You cannot contact other users because you have not {url|verified your email address}.',
-                            {url => $c->uri_for_action('/account/resend_verification')}),
+                message  => l('You cannot contact other users because you do not have a verified email address.'),
             },
             current_view    => 'Node',
         );

root/user/UserProfile.js

@@ -198,16 +198,10 @@ const UserProfileInformation = ({
                   {noEmailWarning}
                 </>
               )}
-              {' '}
-              {viewingOwnProfile ? (
-                bracketed(
-                  <a href="/account/resend-verification">
-                    {l('resend verification email')}
-                  </a>,
-                )
-              ) : (
+              {viewingOwnProfile ? null : (
                 $c.user && !isAddingNotesDisabled($c.user) ? (
                   <>
+                    {' '}
                     {bracketed(
                       <a href={`/user/${encodedName}/contact`}>
                         {l('send email')}

t/lib/t/MusicBrainz/Server/Controller/UnconfirmedEmailAddresses.pm

@@ -65,7 +65,6 @@ test 'Paths that allow browsing without a confirmed email address' => sub {
   'Controller::Account::register',
   'Controller::Account::register_application',
   'Controller::Account::remove_application',
-  'Controller::Account::resend_verification',
   'Controller::Account::reset_password',
   'Controller::Account::revoke_application_access',
   'Controller::Account::verify_email',