Fix install_subdirs not showing up in intro-install_plan.json

Author: lithomas1

mesonbuild/backend/backends.py

@@ -1757,9 +1757,11 @@ def generate_subdir_install(self, d: InstallData) -> None:
             dst_dir = os.path.join(self.environment.get_prefix(),
                                    sd.install_dir)
             dst_name = os.path.join('{prefix}', sd.install_dir)
+            if sd.install_dir != sd.install_dir_name:
+                dst_name = sd.install_dir_name
             if not sd.strip_directory:
                 dst_dir = os.path.join(dst_dir, os.path.basename(src_dir))
-                dst_name = os.path.join(dst_dir, os.path.basename(src_dir))
+                dst_name = os.path.join(dst_name, os.path.basename(src_dir))
             i = SubdirInstallData(src_dir, dst_dir, dst_name, sd.install_mode, sd.exclude, sd.subproject, sd.install_tag)
             d.install_subdirs.append(i)
 

mesonbuild/build.py

@@ -202,6 +202,7 @@ class InstallDir(HoldableObject):
     source_subdir: str
     installable_subdir: str
     install_dir: str
+    install_dir_name: str
     install_mode: 'FileMode'
     exclude: T.Tuple[T.Set[str], T.Set[str]]
     strip_directory: bool

mesonbuild/interpreter/interpreter.py

@@ -2382,10 +2382,15 @@ def func_install_subdir(self, node: mparser.BaseNode, args: T.Tuple[str],
             FeatureDeprecated.single_use('install_subdir with empty directory', '0.60.0', self.subproject,
                                          'It worked by accident and is buggy. Use install_emptydir instead.', node)
 
+        idir_name = kwargs['install_dir']
+        if isinstance(idir_name, P_OBJ.OptionString):
+            idir_name = idir_name.optname
+
         idir = build.InstallDir(
             self.subdir,
             args[0],
             kwargs['install_dir'],
+            idir_name,
             kwargs['install_mode'],
             exclude,
             kwargs['strip_directory'],

mesonbuild/mintro.py

@@ -134,8 +134,10 @@ def list_install_plan(installdata: backends.InstallData) -> T.Dict[str, T.Dict[s
         'data': installdata.data,
         'man': installdata.man,
         'headers': installdata.headers,
+        'install_subdirs': installdata.install_subdirs
     }.items():
-        for data in data_list:
+        # Mypy doesn't recognize SubdirInstallData as a subclass of InstallDataBase
+        for data in data_list: # type: ignore[attr-defined]
             data_type = data.data_type or key
             install_path_name = data.install_path_name
             if key == 'headers':  # in the headers, install_path_name is the directory

mesonbuild/modules/unstable_external_project.py

@@ -245,6 +245,7 @@ def _create_targets(self, extra_depends: T.List[T.Union['BuildTarget', 'CustomTa
         idir = build.InstallDir(self.subdir.as_posix(),
                                 Path('dist', self.rel_prefix).as_posix(),
                                 install_dir='.',
+                                install_dir_name='.',
                                 install_mode=None,
                                 exclude=None,
                                 strip_directory=True,

unittests/allplatformstests.py

@@ -4284,6 +4284,12 @@ def output_name(name, type_):
                     'destination': '{includedir}/foo3-devel.h',
                     'tag': 'devel',
                 },
+            },
+            'install_subdirs': {
+                f'{testdir}/custom_files': {
+                    'destination': '{datadir}/custom_files',
+                    'tag': 'custom'
+                }
             }
         }