Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CRD validation and configuration initialization logic #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Prajwal-kp-18
Copy link

Description
This PR improves MeshSync's CRD validation logic by adding strict field validation and implementing default configuration initialization when needed, which enhances reliability during controller reconciliation.

This PR fixes #375

Changes

  • Added validation for required fields in MeshSync CRD (spec, watch-list, version)
  • Fixed error message capitalization to follow Go conventions
  • Implemented default configuration initialization function
  • Added comprehensive unit tests for validation logic

Notes for Reviewers

PR Summary

Improved MeshSync’s custom resource validation by adding required field checks and initializing default configurations in the controller’s reconciliation loop.

  • Yes, I signed my commits.

Copy link

welcome bot commented Mar 20, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CRD validation and configuration initialization logic in the controller
1 participant