Merge pull request #302 from mergestat/lint-fixes

chore: update some lint issues (deprecated std lib packages)

Author: patrickdevivo

cmd/root.go

@@ -3,7 +3,7 @@ package cmd
 import (
 	"database/sql"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"os"
 	"path/filepath"
 	"time"
@@ -97,7 +97,7 @@ Example queries can be found in the GitHub repo: https://github.com/mergestat/me
 			query = args[0]
 		} else if isPiped(info) {
 			var stdin []byte
-			if stdin, err = ioutil.ReadAll(os.Stdin); err != nil {
+			if stdin, err = io.ReadAll(os.Stdin); err != nil {
 				handleExitError(fmt.Errorf("failed to read from stdin: %v", err))
 			}
 			query = string(stdin)

cmd/serve.go

@@ -4,7 +4,7 @@ import (
 	"database/sql"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 
 	"github.com/mergestat/mergestat-lite/pkg/display"
@@ -71,7 +71,7 @@ func (h *queryServiceHandler) httpHandler(w http.ResponseWriter, req *http.Reque
 
 	var body []byte
 	var err error
-	if body, err = ioutil.ReadAll(req.Body); err != nil {
+	if body, err = io.ReadAll(req.Body); err != nil {
 		h.handleErr(w, http.StatusBadRequest, err)
 		return
 	}

extensions/internal/enry/enry_detect_language_test.go

@@ -1,15 +1,15 @@
 package enry
 
 import (
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"github.com/mergestat/mergestat-lite/extensions/internal/tools"
 )
 
 func TestEnryDetectLanguage(t *testing.T) {
 	path := "./testdata/main.go"
-	fileContents, err := ioutil.ReadFile(path)
+	fileContents, err := os.ReadFile(path)
 	if err != nil {
 		t.Fatal(err)
 	}

extensions/internal/enry/enry_is_binary_test.go

@@ -1,15 +1,15 @@
 package enry
 
 import (
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"github.com/mergestat/mergestat-lite/extensions/internal/tools"
 )
 
 func TestEnryIsBinary(t *testing.T) {
 	path := "./testdata/binary"
-	fileContents, err := ioutil.ReadFile(path)
+	fileContents, err := os.ReadFile(path)
 	if err != nil {
 		t.Fatal(err)
 	}

extensions/internal/git/native/files_test.go

@@ -2,7 +2,7 @@ package native_test
 
 import (
 	"fmt"
-	"io/ioutil"
+	"os"
 	"testing"
 )
 
@@ -49,7 +49,7 @@ func TestSelectKnownContents(t *testing.T) {
 		}
 		t.Logf("file: path=%s contents_len=%d", path, len(contents))
 
-		expectedFileContents, err := ioutil.ReadFile(fmt.Sprintf("./testdata/%s/%s.testdata", hash, path))
+		expectedFileContents, err := os.ReadFile(fmt.Sprintf("./testdata/%s/%s.testdata", hash, path))
 		if err != nil {
 			t.Fatalf("failed to load fixture file: %v", err)
 		}

extensions/internal/golang/go_mod_to_json_test.go

@@ -2,14 +2,14 @@ package golang
 
 import (
 	"encoding/json"
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"github.com/mergestat/mergestat-lite/extensions/internal/tools"
 )
 
 func TestGoModToJSONOK(t *testing.T) {
-	goMod, err := ioutil.ReadFile("testdata/GoModOK")
+	goMod, err := os.ReadFile("testdata/GoModOK")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -58,7 +58,7 @@ func TestGoModToJSONEmpty(t *testing.T) {
 }
 
 func TestGoModToJSONMissingVals(t *testing.T) {
-	goMod, err := ioutil.ReadFile("testdata/GoModMissingVals")
+	goMod, err := os.ReadFile("testdata/GoModMissingVals")
 	if err != nil {
 		t.Fatal(err)
 	}

extensions/internal/npm/npm.go

@@ -4,7 +4,7 @@ package npm
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 
 	"github.com/mergestat/mergestat-lite/extensions/options"
@@ -49,7 +49,7 @@ func (c *Client) GetPackage(ctx context.Context, packageName string) ([]byte, er
 		return nil, err
 	}
 
-	body, err := ioutil.ReadAll(res.Body)
+	body, err := io.ReadAll(res.Body)
 	if err != nil {
 		return nil, err
 	}
@@ -72,7 +72,7 @@ func (c *Client) GetPackageVersion(ctx context.Context, packageName, version str
 		return nil, err
 	}
 
-	body, err := ioutil.ReadAll(res.Body)
+	body, err := io.ReadAll(res.Body)
 	if err != nil {
 		return nil, err
 	}

pkg/locator/locator.go

@@ -9,7 +9,6 @@ package locator
 
 import (
 	"context"
-	"io/ioutil"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -66,7 +65,7 @@ func determineCloneDir(path, baseCloneDir string) (string, bool, error) {
 
 	// if no clone directory is specified, use a tmp dir
 	if baseCloneDir == "" {
-		if baseCloneDir, err = ioutil.TempDir(os.TempDir(), "mergestat"); err != nil {
+		if baseCloneDir, err = os.MkdirTemp("", "mergestat"); err != nil {
 			return "", false, errors.Wrap(err, "failed to create a temporary directory")
 		}