Skip to content

Commit 924c08e

Browse files
authored
Merge pull request #392 from nada-ben-ali/NaBe/revert_comparaminstance_short_name
comparaminstance.spec property is not available during object creation
2 parents 1e5f030 + 6f66a07 commit 924c08e

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

odxtools/comparamsubset.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,16 @@ class ComparamSubset(OdxCategory):
2929
def from_et(et_element: ElementTree.Element,
3030
doc_frags: List[OdxDocFragment]) -> "ComparamSubset":
3131

32-
cat = OdxCategory.category_from_et(et_element, doc_frags, doc_type=DocType.COMPARAM_SUBSET)
32+
category = et_element.get("CATEGORY")
33+
34+
# In ODX 2.0, COMPARAM-SPEC is used, whereas in ODX 2.2, it refers to something else and has been replaced by COMPARAM-SUBSET.
35+
# - If 'category' is missing (ODX 2.0), use COMPARAM_SPEC,
36+
# - else (ODX 2.2), use COMPARAM_SUBSET.
37+
doc_type = DocType.COMPARAM_SUBSET if category else DocType.COMPARAM_SPEC
38+
cat = OdxCategory.category_from_et(et_element, doc_frags, doc_type=doc_type)
3339
doc_frags = cat.odx_id.doc_fragments
3440
kwargs = dataclass_fields_asdict(cat)
3541

36-
category = et_element.get("CATEGORY")
37-
3842
data_object_props = NamedItemList([
3943
DataObjectProperty.from_et(el, doc_frags)
4044
for el in et_element.iterfind("DATA-OBJECT-PROPS/DATA-OBJECT-PROP")

0 commit comments

Comments
 (0)