Skip to content

duplicate key 'light_lux' #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Feb 19, 2022 · 4 comments
Closed

duplicate key 'light_lux' #1986

ghost opened this issue Feb 19, 2022 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 19, 2022

key light_lux is now duplicate in

https://github.com/merbanan/rtl_433/blob/master/examples/rtl_433_mqtt_hass.py

    },
    "light_lux": {
        "device_type": "sensor",
        "object_suffix": "lux",
        "config": {
            "name": "Outside Luminancee",
            "unit_of_measurement": "lux",
            "value_template": "{{ value|int }}",
            "state_class": "measurement"
        }
    },
    "light_lux": {
        "device_type": "sensor",
        "object_suffix": "lux",
        "config": {
            "name": "Outside Luminancee",
            "unit_of_measurement": "lux",
            "value_template": "{{ value|int }}",
            "state_class": "measurement"
        }
    },

introduced with a combination of commits from issues #1930 and #1584

@zuckschwerdt
Copy link
Collaborator

Thanks! Do you want to PR a fix?

@joanwa
Copy link
Contributor

joanwa commented Feb 20, 2022

sure, just wondering if lux is still required for some backwards/legacy compatibility... so either

  1. kick the duplicate
  2. renaming one light_lux back to lux

@zuckschwerdt
Copy link
Collaborator

That was just a bad combination of merges on my part. There is still an about even split of "light_lux" and "lux" fields in current decoders. We should rename it back.
For the future we should formalize more of the weather device keys and possibly migrate.

@joanwa
Copy link
Contributor

joanwa commented Feb 20, 2022

fixed with 88b7a24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants