Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent create_col for the vectorstores #2497

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Consistent create_col for the vectorstores #2497

wants to merge 2 commits into from

Conversation

parshvadaftari
Copy link
Contributor

Description

Consistent create_col for vectorstores

Fixes #2465

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@Dev-Khant
Copy link
Member

@parshvadaftari Can you please resolve the merge conflicts?

@parshvadaftari
Copy link
Contributor Author

@Dev-Khant Resolved the conflicts and formatted the code as well.

Dev-Khant
Dev-Khant reviewed Apr 11, 2025
View reviewed changes
examples/livekit-mem0/memory_voice_agent.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey please can you remove this? We already have livekit integration here: https://docs.mem0.ai/integrations/livekit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes have removed it.

@Dev-Khant
Copy link
Member

Hey @parshvadaftari Can you please rebase your branch with main?

@parshvadaftari parshvadaftari force-pushed the consistent__create_col branch from 990fd9a to bb5b677 Compare April 11, 2025 18:33
@parshvadaftari
Copy link
Contributor Author

@Dev-Khant Have resolved the conflicts, rebased it with main and made the create_col consistent with the newer vectorstores introduced. Do let me know if there are any other changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dev-Khant Dev-Khant Dev-Khant left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make create_col consistent for all Vector Stores
2 participants
@parshvadaftari @Dev-Khant