Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional assetPrefix for dev mode to fix CSS loading #2445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lemorage
Copy link

Description

When running the app in development mode, Next.js serves assets locally (http://localhost:3000/_next/static/...), but the assetPrefix config in next.config.ts is telling it to fetch them from https://demo.mem0.ai. This will make these requests fail with a 404, and the stylesheets don’t load.

This PR resolves this issue by adding a conditional check to avoid this. Plus, the preload: false is added to fonts, fixing the link preload warning in Next.js.

Fixes #2444

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested by pnpm run dev, all the assets can be found by Next.js, and the demo website works properly.

https://docs.mem0.ai/examples/mem0-demo#enhancing-the-next-js-application

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mem0 demo local deployment problem
2 participants