Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pointing to item directly in split nodes #119

Open
3 tasks
Tracked by #118
irevoire opened this issue Apr 3, 2025 · 0 comments · May be fixed by #120
Open
3 tasks
Tracked by #118

Stop pointing to item directly in split nodes #119

irevoire opened this issue Apr 3, 2025 · 0 comments · May be fixed by #120

Comments

@irevoire
Copy link
Member

irevoire commented Apr 3, 2025

Currently, when crafting split nodes, arroy may output a direct link to an item on one of its sides.
That’s an optimization that removes one indirection:

  • But it practically never happens in real life
  • /!\ It stops us from multi-threading some parts of the code

We should update the split node creation to include only other tree nodes (descendants or other split nodes).
This is a DB breaking, which means:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant