Merge pull request #71 from medic/1147-exists-validation-unicode-fix

modified validation lib to better support unicode query values.

Author: garethbowen

lib/validation.js

@@ -32,10 +32,13 @@ var _exists = function(doc, query, callback) {
 };
 
 var _formatParam = function(name, value) {
-    return encodeURIComponent(name) + ':"' + encodeURIComponent(value) + '"';
+    name = name.replace(/"/g, '');
+    value = value.replace(/"/g, '\\"');
+    return name + ':"' + value + '"';
 };
 
 module.exports = {
+    _formatParam: _formatParam,
     extractErrors: function(result, messages, ignores) {
         // wrap single item in array; defaults to empty array
         ignores = ignores || [];

test/unit/validations.js

@@ -244,6 +244,27 @@ exports['pass uniqueWithin validation on old doc'] = function(test) {
     });
 };
 
+exports['formatParam does not encode unicode'] = function(test) {
+    test.same(validation._formatParam('form', 'द'), 'form:"द"');
+    test.done();
+};
+
+exports['formatParam escapes quotes in values'] = function(test) {
+    test.same(
+        validation._formatParam('form', ' " AND everything'),
+        'form:" \\" AND everything"'
+    );
+    test.done();
+};
+
+exports['formatParam rejects quotes in field names'] = function(test) {
+    test.same(
+        validation._formatParam('*:"everything', 'xyz'),
+        '*:everything:"xyz"'
+    );
+    test.done();
+};
+
 exports['pass exists validation when matching document'] = function(test) {
     test.expect(2);
     // simulate view results with doc attribute