Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moment patch in webapp #9839

Open
dianabarsan opened this issue Mar 14, 2025 · 6 comments
Open

Update moment patch in webapp #9839

dianabarsan opened this issue Mar 14, 2025 · 6 comments
Assignees
Labels
Help wanted The CHT is looking for help! Type: Technical issue Improve something that users won't notice

Comments

@dianabarsan
Copy link
Member

Describe the issue
We have a small patch for moment in webapp (that pertains to displaying numbers in hindi).
However the patch was made for an older version of moment, and patch-package complains when building webapp:

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    [email protected]

  applied to

    [email protected]
  
  At path
  
    node_modules/moment

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package moment

  to update the version in the patch file name and make this warning go away.

Describe the improvement you'd like
Update the patch file to match the version of moment.

@dianabarsan dianabarsan added Type: Technical issue Improve something that users won't notice Help wanted The CHT is looking for help! labels Mar 14, 2025
@saurabh12nxf
Copy link

"Hi[@dianabarsan ], I’d love to work on this issue! I’ll update the patch file for Moment.js to match the latest version (2.30.1). Can you assign this to me?"

@dianabarsan
Copy link
Member Author

Hi @saurabh12nxf ! I'm so happy to read this :) Please let me know if there's anything that I can assist with. Good luck!

@saurabh12nxf
Copy link

saurabh12nxf commented Mar 29, 2025

Hi @dianabarsan like i am getting issue in setting up the project locally and the issue is related to installation of dependencies:

15421 verbose stack at callLimit (/home/saurabh/.nvm/versions/node/v22.14.0/lib/node_modules/npm/node_modules/promise-call-limit/dist/commonjs/index.js:35:69)
15422 verbose pkgid @medic/[email protected]
15423 error code 2
15424 error path /mnt/c/Users/HP/Desktop/Cht Core/cht-core/shared-libs/cht-datasource
15425 error command failed
15426 error command sh -c rm -rf dist && npm run build
15427 error > @medic/[email protected] build
15427 error > tsc -p tsconfig.build.json
15427 error
15427 error src/local/libs/doc.ts(26,13): error TS2339: Property 'doc' does not exist on type '{ key: string; error: "not_found"; } | { doc?: ExistingDocument<Doc & AllDocsMeta> | null | undefined; id: string; key: string; value: { rev: string; deleted?: boolean | undefined; }; }'.
15428 error npm error Lifecycle script build failed with error:

please assist me

@dianabarsan
Copy link
Member Author

Hi @saurabh12nxf

Can you please share which commands you're running?

@saurabh12nxf
Copy link

Hi @dianabarsan
I ran those commands which are mention on contribution guidelines and
i am running windows commands .
https://docs.communityhealthtoolkit.org/contribute/code/core/dev-environment/

@dianabarsan
Copy link
Member Author

Hi @saurabh12nxf

Can you still please share which commands you are running and where installation steps are failing?
Since this is not related to the current issue, could you please open a topic on the forum to get technical support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted The CHT is looking for help! Type: Technical issue Improve something that users won't notice
Projects
None yet
Development

No branches or pull requests

2 participants