refactor lineage check using hasInvalidContactLineageForField

Signed-off-by: Apoorva Pendse <[email protected]>

Author: apoorvapendse

shared-libs/cht-datasource/src/qualifier.ts

@@ -331,7 +331,8 @@ export const isPersonQualifier = (data: unknown): data is PersonQualifier => {
   if (!checkContactQualifierFields(data)) {
     return false;
   }
-
+  
+  // `parent` must be present for person, so cannot use `hasInvalidContactLineageForField` 
   if (!hasField(data, { name: 'parent', type: 'object' }) || !isNormalizedParent(data.parent)) {
     return false;
   }
@@ -430,23 +431,44 @@ const checkFieldLineageAndThrowError = (data: Record<string, unknown>, field?:st
   }
 };
 
+/** @internal*/
+const hasInvalidContactLineageForField = (data: Record<string, unknown>, field?:string) => {
+  let hierarchyRoot = data;
+  let normalized_parent = data.parent;
+  
+  if (field && hasField(data, {name: field, type: 'object'})) {
+    hierarchyRoot = data[field] as unknown as Record<string, unknown>;
+    normalized_parent = data[field];
+  }
+
+  // `parent` is optional, so this lineage is valid
+  if (!hasField(hierarchyRoot, {type: 'object', name: 'parent'})){
+    return false;
+  }
+  
+  if (!isNormalizedParent(normalized_parent)) {
+    // eslint-disable-next-line max-len
+    return true;
+  }
+  if (hasBloatedLineage(hierarchyRoot)) {
+    // eslint-disable-next-line max-len
+    return true;
+  }
+};
+
 
 /** @internal*/
 export const isPlaceQualifier = (data:unknown) : data is PlaceQualifier => {
   if (!checkContactQualifierFields(data)) {
     return false;
   }
 
-  if (hasField(data, { name: 'parent', type: 'object' })) {
-    if (!isNormalizedParent(data.parent) || hasBloatedLineage(data)){
-      return false;
-    }
+  if (hasInvalidContactLineageForField(data)){
+    return false;
   }
 
-  if (hasField(data, {name: 'contact', type: 'object'})) {
-    if (!isNormalizedParent(data.contact) || hasBloatedLineage(data.contact)){
-      return false;
-    }
+  if (hasInvalidContactLineageForField(data, 'contact')){
+    return false;
   }
 
   return hasValidContactType(data) || hasValidLegacyContactType(data, 'place');