Skip to content

Commit 7907038

Browse files
osazosDecayConstant
authored andcommitted
AdagioBidAdapter: validate plcmt video param () (prebid#11487)
1 parent cefbbe5 commit 7907038

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

modules/adagioBidAdapter.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,11 @@ export const ORTB_VIDEO_PARAMS = {
6464
'w': (value) => isInteger(value),
6565
'h': (value) => isInteger(value),
6666
'startdelay': (value) => isInteger(value),
67-
'placement': (value) => isInteger(value),
67+
'placement': (value) => {
68+
logWarn(LOG_PREFIX, 'The OpenRTB video param `placement` is deprecated and should not be used anymore.');
69+
return isInteger(value)
70+
},
71+
'plcmt': (value) => isInteger(value),
6872
'linearity': (value) => isInteger(value),
6973
'skip': (value) => [1, 0].includes(value),
7074
'skipmin': (value) => isInteger(value),
@@ -964,6 +968,7 @@ export const spec = {
964968

965969
autoFillParams(bid);
966970

971+
// Note: `bid.params.placement` is not related to the video param `placement`.
967972
if (!(bid.params.organizationId && bid.params.site && bid.params.placement)) {
968973
logWarn(`${LOG_PREFIX} at least one required param is missing.`);
969974
// internal.enqueue(debugData());

test/spec/modules/adagioBidAdapter_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ describe('Adagio bid adapter', () => {
493493
skipafter: 4,
494494
minduration: 10,
495495
maxduration: 30,
496-
placement: 3,
496+
plcmt: 4,
497497
protocols: [8]
498498
}
499499
}).build();
@@ -508,7 +508,7 @@ describe('Adagio bid adapter', () => {
508508
skipafter: 4,
509509
minduration: 10,
510510
maxduration: 30,
511-
placement: 3,
511+
plcmt: 4,
512512
protocols: [8],
513513
w: 300,
514514
h: 250

0 commit comments

Comments
 (0)