Skip to content

Commit 6604eda

Browse files
uditaliasDecayConstant
authored andcommitted
Various Adapters: Use Vidazoo utils lib to remove code duplications (prebid#11888)
* vidazooUtils - single request configurations * fix: shines rtb adapter use vidazoo bidder utils * fix: added vidazoo utils to illimin adapter * fix: illumin bid adapter using vidazooUtils * fix: twistDigital adapter use vidazooUtils * fix: tagoras adapter use vidazooUtils * fix: kueezRtb adapter use vidazooUtils * fix: removed parrable and digitrust id systems
1 parent 19bac78 commit 6604eda

12 files changed

+191
-1748
lines changed

libraries/vidazooUtils/bidderUtils.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ export function appendUserIdsToRequestPayload(payloadRef, userIds) {
200200
let key;
201201
_each(userIds, (userId, idSystemProviderName) => {
202202
key = `uid.${idSystemProviderName}`;
203+
203204
switch (idSystemProviderName) {
204205
case 'lipb':
205206
payloadRef[key] = userId.lipbid;
@@ -217,7 +218,7 @@ export function getVidazooSessionId(storage) {
217218
return getStorageItem(storage, SESSION_ID_KEY) || '';
218219
}
219220

220-
export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout, webSessionId, storage, bidderVersion, bidderCode, getUniqueRequestData) {
221+
export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout, storage, bidderVersion, bidderCode, getUniqueRequestData) {
221222
const {
222223
params,
223224
bidId,
@@ -234,7 +235,7 @@ export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidder
234235
const {ext} = params;
235236
let {bidFloor} = params;
236237
const hashUrl = hashCode(topWindowUrl);
237-
const uniqueRequestData = isFn(getUniqueRequestData) ? getUniqueRequestData(hashUrl) : {};
238+
const uniqueRequestData = isFn(getUniqueRequestData) ? getUniqueRequestData(hashUrl, bid) : {};
238239
const uniqueDealId = getUniqueDealId(storage, hashUrl);
239240
const pId = extractPID(params);
240241
const isStorageAllowed = bidderSettings.get(bidderCode, 'storageAllowed');
@@ -285,7 +286,6 @@ export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidder
285286
bidderRequestsCount: bidderRequestsCount,
286287
bidderWinsCount: bidderWinsCount,
287288
bidderTimeout: bidderTimeout,
288-
webSessionId: webSessionId,
289289
...uniqueRequestData
290290
};
291291

@@ -331,13 +331,13 @@ export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidder
331331
return data;
332332
}
333333

334-
export function createInterpretResponseFn(bidderCode) {
334+
export function createInterpretResponseFn(bidderCode, allowSingleRequest) {
335335
return function interpretResponse(serverResponse, request) {
336336
if (!serverResponse || !serverResponse.body) {
337337
return [];
338338
}
339339

340-
const singleRequestMode = config.getConfig(`${bidderCode}.singleRequest`);
340+
const singleRequestMode = allowSingleRequest && config.getConfig(`${bidderCode}.singleRequest`);
341341
const reqBidId = deepAccess(request, 'data.bidId');
342342
const {results} = serverResponse.body;
343343

@@ -410,12 +410,12 @@ export function createInterpretResponseFn(bidderCode) {
410410
}
411411
}
412412

413-
export function createBuildRequestsFn(createRequestDomain, createUniqueRequestData, webSessionId, storage, bidderCode, bidderVersion) {
413+
export function createBuildRequestsFn(createRequestDomain, createUniqueRequestData, storage, bidderCode, bidderVersion, allowSingleRequest) {
414414
function buildRequest(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout) {
415415
const {params} = bid;
416416
const cId = extractCID(params);
417417
const subDomain = extractSubDomain(params);
418-
const data = buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout, webSessionId, storage, bidderVersion, bidderCode, createUniqueRequestData);
418+
const data = buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout, storage, bidderVersion, bidderCode, createUniqueRequestData);
419419
const dto = {
420420
method: 'POST', url: `${createRequestDomain(subDomain)}/prebid/multi/${cId}`, data: data
421421
};
@@ -428,7 +428,7 @@ export function createBuildRequestsFn(createRequestDomain, createUniqueRequestDa
428428
const subDomain = extractSubDomain(params);
429429
const data = bidRequests.map(bid => {
430430
const sizes = parseSizesInput(bid.sizes);
431-
return buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout, webSessionId, storage, bidderVersion, bidderCode, createUniqueRequestData)
431+
return buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidderTimeout, storage, bidderVersion, bidderCode, createUniqueRequestData)
432432
});
433433
const chunkSize = Math.min(20, config.getConfig(`${bidderCode}.chunkSize`) || 10);
434434

@@ -445,11 +445,10 @@ export function createBuildRequestsFn(createRequestDomain, createUniqueRequestDa
445445
}
446446

447447
return function buildRequests(validBidRequests, bidderRequest) {
448-
// TODO: does the fallback make sense here?
449448
const topWindowUrl = bidderRequest.refererInfo.page || bidderRequest.refererInfo.topmostLocation;
450449
const bidderTimeout = config.getConfig('bidderTimeout');
451450

452-
const singleRequestMode = config.getConfig('vidazoo.singleRequest');
451+
const singleRequestMode = allowSingleRequest && config.getConfig(`${bidderCode}.singleRequest`);
453452

454453
const requests = [];
455454

0 commit comments

Comments
 (0)