-
Notifications
You must be signed in to change notification settings - Fork 23
[Feature request] Support setting serial to generic #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Such crappy readers exist? Oo Sure it's not the media? Usually I would just refuse adding code to support trash-hardware or software, esp. since it reduces security. But we already have the Generic options for vendor and model and it will be optional anyway... Soooooo.... Will be added SOMEWHEN, but feel free to submit a PR if you're in a hurry. |
Too lazy to test, but in theory it's available in branch issue-261-support-generic-serial |
thanks for the quick update, will hopefully have some time to test this week! |
So I installed it like this: git checkout issue-261-support-generic-serial
git diff origin #looks good
make && sudo make install
echo $? # is 0
reboot Then changed everything but the vol id to Generic. Does not work because it cant find the device... only tried with FAT vol Serial needs to be set. Everything else can be Generic |
Thanks for doing the testing I should have done :D But it's easier with a
matching device.
Now as you say it, I think the serial is used to search for the volume.
Gonna re-check this (somewhen, not asap ^^ sry)
Am Mo., 3. Feb. 2025 um 22:18 Uhr schrieb v-Nyo ***@***.***>:
… only tried with FAT vol
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZI2U77BZHWJ6HF33PSFR32N7MLXAVCNFSM6AAAAABUTB57I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZSGA4TQMJWGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
No worries it's not urgent. I am just grateful for you maintenance of this project ^_^ |
I just looked at the code and actually it should work.
If you find something let me know, but I won't put further time into this
topic since it's such a niche case caused by cheap hardware.
Am Mi., 5. Feb. 2025 um 22:51 Uhr schrieb v-Nyo ***@***.***>:
… No worries it's not urgent. I am just grateful for you maintenance of this
project ^_^
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZI2U6E2IELQTYNEUEDD2T2OKBUXAVCNFSM6AAAAABUTB57I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZYGA4TSOJSGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Maybe I am just to stupid to install the commit properly. Will try again when it's merged into master. Would appreciate if you could at least quickly test if your device still gets recognized when you set it's serial to Generic. |
Just tested it myself, there were indead two lines missing to make it work
:D Just pushed the fix.
Try it again please, works on my machine (with a proper drive though, just
serial set to Generic in config)
Am Fr., 14. Feb. 2025 um 16:10 Uhr schrieb v-Nyo ***@***.***>:
… Maybe I am just to stupid to install the commit properly. Will try again
when it's merged into master.
Would appreciate if you could at least quickly test if your device still
gets recognized when you set it's serial to Generic.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZI2UZ2GBEUTCP3CTOJXUT2PYBPNAVCNFSM6AAAAABUTB57I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGU4DEMJUGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: v-Nyo]*v-Nyo* left a comment (mcdope/pam_usb#261)
<#261 (comment)>
Maybe I am just to stupid to install the commit properly. Will try again
when it's merged into master.
Would appreciate if you could at least quickly test if your device still
gets recognized when you set it's serial to Generic.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZI2UZ2GBEUTCP3CTOJXUT2PYBPNAVCNFSM6AAAAABUTB57I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGU4DEMJUGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Thank you very much. I also had to set the Model (which was previously "MassStorageClass") also to Generic (Otherwise it would get stuck on the first drive), but now a I can add as many drives via this reader as I want! The only thing worth mentioning would be that the warning for Model/Vendor gets printed 3 times each, kinda pollutes the log. |
Okay maybe that was too early. How is it when you have 2 Devices with everything set to Generic? I have issues when both drives are all generic. The first ones get's skipped but the second one works without any issues. ( And only the first ones prints the warning 3 times each). When I set the model of the first one to MassStorageClass it starts working again but the second one only works once (the first time you unlock after changing the conf). IDK what's going on here. I think you should test if it works on you Machine with 2 devices all Generic and if it does close this issue. I don't want to steal more of you time when almost nobody is benefiting from this feature. Maybe this SD reader is really beyond saving. |
Rebooted and tried to add a third device. From what I can tell it always get's stuck on the first device where everything but the vol. id is generic. It falsely detects that the first drive is connected and tries to probe for that volume (does not check if the UUID of the partition is there). Also I don't get the warning printed 3 times each anymore ( only shows up when Model is not generic) |
Well good news is that it's now a lot more stable. Before setting everything to generic I had to deal with a lot of timeouts / connections issues, now works like a breeze. I am satisfied with the current state. I would merge the pull request and add a quick note that setting serial to generic is not fully supported, has issues and link to this thread? (If you see no real benefit in fixing this) Anyway thanks for you time. |
That is kinda an expected sideeffect and unlikely to change. But again: your cardreader is utterly broken, you should just use proper devices. As soon as ANY field is set to generic, you're reducing the already low security of pam_usb.
Glad it workarounded your "wtf hardware" 😁
I don't plan to merge this into master since it has too many caveats and is only required for very niche and very broken hardware. You will have to either stick to your current build, or to be able to update: maintain your own branch forked from master but merging this and then do local builds. |
Alright no problem, thanks |
Uh oh!
There was an error while loading. Please reload this page.
Understood
Yes, this is not a bug report / support request
Text
The built in sdcard reader on my laptop does not report the vendor/model and always the same serial no matter the card plugged in.
Because of this I can only register a single sdcard.
The text was updated successfully, but these errors were encountered: