Skip to content

"Undo close tab" missing from context menu #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbaz opened this issue Mar 25, 2019 · 10 comments
Closed

"Undo close tab" missing from context menu #16

mbaz opened this issue Mar 25, 2019 · 10 comments

Comments

@mbaz
Copy link

mbaz commented Mar 25, 2019

The context menu has some very useful options, but it's missing "undo close tab", which I find essential to recover tabs closed by accident.

Sideberry v2.2.1, Firefox 66.0, Archlinux.

@mbnuqw
Copy link
Owner

mbnuqw commented Mar 26, 2019

Yep, I plan to add Undo action (for bookmarks and tabs). And I want to add ability to choose removed item[s] to restore. But I don't know yet how to implement it in UI. Since it's a general action I cannot just add it to context menu.
Options are:
-- add it in dashboard menu
-- show button at the bottom after some tab/bookmark was closed

And I don't really like both of these options...
Anyway, I need to test different variants.

@mbaz
Copy link
Author

mbaz commented Mar 26, 2019

One idea would be to add a context menu option to just restore the most recently closed tab. That is what Vertical Tabs Reloaded and Tree Style Tabs do. For more fine-grained tab restoring, Firefox's "history" menu already provides a list of recently closed tabs, so you may not need to re-implement that.

Restoring deleted bookmarks is an intriguing idea. I've never needed it, but I do backup my bookmarks every once in a while...

@mbnuqw
Copy link
Owner

mbnuqw commented Mar 26, 2019

You right, I somehow forget about "Library/History" menu 😄

What if I add customizable strip with "easy access" actions?
Something like that (this is just random icons):
screenshot-2019 03 26-23 12 50_1

So you can assign Undo and any action you want.

...and even more, I can allow user to completely customize context menu.
hm... I need some time to test it.

@mbaz
Copy link
Author

mbaz commented Mar 26, 2019

That'd be awesome.

@mbnuqw mbnuqw added this to the v2.4.0 milestone Mar 31, 2019
@mbnuqw mbnuqw closed this as completed in ce9046e Apr 14, 2019
@mbaz
Copy link
Author

mbaz commented Apr 14, 2019

Seems to work -- thanks!

@Jipok
Copy link

Jipok commented Jun 2, 2019

On my system it looks like this:
image
What in my opinion is unfortunate. I thought this was the "Go back one page" button and only a search on the github questions made it clear where the "Undo close tab" is located.

@mbnuqw
Copy link
Owner

mbnuqw commented Jun 2, 2019

Hmm, you are right, icon can be counterintuitive and unfortunately there are only two ways for new user to know what it means - read tooltip on mouse hover or just click on it. If you have any suggestions of how this icon should look like, feel free to open new issue.

@Jipok
Copy link

Jipok commented Jun 3, 2019

Most common icons:
image
From flaticon
Can also be found here.

image
From Nerd fonts.

I think the third option (the most right) looks better.

@Jipok
Copy link

Jipok commented Jun 3, 2019

In TST for this action you need to install one of several external add-ons. Therefore i think the “Undo Close Tab” feature is worth mentioning in the features list or in the tips and tricks.

@TheOverpassArsonist
Copy link

I also absent mindedly thought it was a back button but discovered what it was by looking up how to undo a tab close was when I found this post. (though tbf I'd consider this user-error since, why tf would that be a back button? And, eitherway, I definitely should've at least hovered over it to read the tooltip)

With that said however, I do think the icon could be changed to improve clarity of function. (user error or not) I am by no means a graphical artist or UI designer, but I think repurposing the existing 'closed tabs'/'trash' icon would be a good idea here, since conceptually they share a near-identical purpose.
Image

In normal use it would look something like this

Image

and then if the user clicks on that it will pull up the existing closed-tabs window that this icon is already currently associated with (note : the UI pedant in me finds it a bit annoying that hitting the button that could be anywhere in the panel opens up a new change on the bottom of the panel, but tbh I don't think there's any way around that)

but then if the user has closed a tab or tab-tree in the past 10-30 seconds it will look like this

Image

and clicking on it would restore the last closed item.

This would make it incredibly clear what the button does and make it also have a use outside of just restoring the last closed tab. (since I'm not sure I have ever reopened my last closed tab when that tab was closed >30s ago.)

Also, I'm not sure if it's possible but I'd personally appreciate it if a similar behaviour existed for ctrl-z, so if a tab (or tab tree) was closed in the past 5-10 seconds pressing ctrl-z would automatically restore it. (though I recognize that this is a new feature that should probably be it's own discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants