Skip to content

[V5] no seperated color scheme for each window. Cycling through all windows if each window has different theme color #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SunnyZebra opened this issue Jul 23, 2023 · 2 comments

Comments

@SunnyZebra
Copy link

Steps to reproduce

Expected behavior

Keep color scheme of each window and update each window only on theme (-moz-dialog?) color update of each window.

Actual behavior

ColorScheme cycling through all windows until it settles on the current active window. On tab/window change color cycling through all windows again.
Sidebery can currently [v5.0.0rc4] not have separated different theme colors for each window at the same time.
Simple Auto:Dark/Light not (visibly?) cycling through all window colors again.

Debug info

Addon data
To get addon data: 
- Go to the Sidebery settings page - section "Help"
- Click on the "Debug info" button
- Copy and paste here inside this codeblock, replacing this text.
Note: all URLs, titles and other personal info are skipped.
Logs
To get logs: 
- Open DevTools (open this url in new tab: about:devtools-toolbox?id=%7B3c078156-979c-498b-8990-85f7987dd929%7D&type=extension).
- Navigate to "console" tab.
- Click on the trash bin icon (at the top-left) to clear console.
- Then try to reproduce the issue.
- If messages appear, copy and paste them here inside this codeblock, replacing this text.
@emvaized
Copy link
Contributor

Did you tried changing Sidebery color scheme to "firefox", as it was suggested here?

@SunnyZebra
Copy link
Author

Highlevel nagging since it uses an additional addon Adaptive Tab Bar Color to dynamically change window theme color.

Setting color scheme to firefox already done. The other settings with constant window color are working fine. If there is only dark, light or constant custom theme there is no issue since windows are not changing theme colors.

Here example image how it looks for me. It is getting the right color, but it is changing all windows to the current focused window theme. Each color change forces a cycling through all windows.

Left window in focus
Screenshot 2023-07-28 134032

Right window in focus
Screenshot 2023-07-28 134055

From that behavior i assume that there is only one global variable to use the current theme color instead of a variable for each window. Somehow the script needs to cycle each window again to get the current window color.
For now i'll just keep it in the dark mode setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants