chore: tabs: pass the flag fromNewTabButton in a consistent manner

Author: capi1O

src/services/tabs.fg.create.ts

@@ -98,7 +98,7 @@ export async function createTabInPanel(panel: Panel, conf?: browser.tabs.CreateP
 
   const tabShell = { fromNewTabButton: true } as Tab
   let index = Tabs.getIndexForNewTab(panel, tabShell)
-  const parentId = Tabs.getParentForNewTab(panel, true)
+  const parentId = Tabs.getParentForNewTab(panel, tabShell)
   if (!Utils.isTabsPanel(panel)) return
   if (index === undefined && panel.nextTabIndex > -1) index = panel.nextTabIndex
 
@@ -803,18 +803,21 @@ function getIndexForNewTabOtherCases(
   return fallbackIndex
 }
 
+interface ParentForNewTabConf {
+  openerTabId?: ID
+  fromNewTabButton?: boolean
+}
+
 /**
  * Find and return parent id
  */
-export function getParentForNewTab(
-  panel: Panel,
-  fromNewTabButton: boolean,
-  openerTabId?: ID
-): ID | undefined {
+export function getParentForNewTab(panel: Panel, conf?: ParentForNewTabConf): ID | undefined {
   const activeTab = Tabs.byId[Tabs.activeId]
 
+  const openerTabId = conf && conf.openerTabId
   let parent: Tab | undefined
   if (openerTabId) parent = Tabs.byId[openerTabId]
+  const fromNewTabButton = conf ? conf.fromNewTabButton : false
 
   // Place new tab opened from pinned tab
   if (parent && parent.pinned) return

src/services/tabs.fg.handlers.ts

@@ -392,7 +392,10 @@ function onTabCreated(nativeTab: NativeTab, attached?: boolean): void {
       index = Tabs.getIndexForNewTab(panel, tab)
       if (!autoGroupTab) {
         if (!Settings.state.groupOnOpen) tab.openerTabId = undefined
-        else tab.openerTabId = Tabs.getParentForNewTab(panel, false, tab.openerTabId)
+        else {
+          const tabShell = { openerTabId: tab.openerTabId, fromNewTabButton: true } as Tab
+          tab.openerTabId = Tabs.getParentForNewTab(panel, tabShell)
+        }
       }
     }
   }