fix: setupPage/navbar: rm non-panel element with "x" button

mbnuqw · mbnuqw · commit b29c69021df6 · 2025-02-20T17:33:00.000+05:00
(resolves #2018)
diff --git a/src/page.setup/components/settings.navbar.vue b/src/page.setup/components/settings.navbar.vue
@@ -310,10 +310,11 @@ function disableBtn(index: number): void {
   if (panelConf) {
     const msg = getRmConfirmMsg(panelConf)
     if (msg && !window.confirm(msg)) return
+
+    delete SidebarConfigRState.panels[panelConf.id]
   }
 
   SidebarConfigRState.nav.splice(index, 1)
-  delete SidebarConfigRState.panels[panelConf.id]
   saveSidebarConfig()
 }
 

Original file line number	Diff line number	Diff line change
`@@ -310,10 +310,11 @@ function disableBtn(index: number): void {`
`310`	`310`	`if (panelConf) {`
`311`	`311`	`const msg = getRmConfirmMsg(panelConf)`
`312`	`312`	`if (msg && !window.confirm(msg)) return`
	`313`	`+`
	`314`	`+ delete SidebarConfigRState.panels[panelConf.id]`
`313`	`315`	`}`
`314`	`316`
`315`	`317`	`SidebarConfigRState.nav.splice(index, 1)`
`316`		`- delete SidebarConfigRState.panels[panelConf.id]`
`317`	`318`	`saveSidebarConfig()`
`318`	`319`	`}`
`319`	`320`