Skip to content

Commit 67e978d

Browse files
committed
Fixed: Tabs: Pinning tab triggers switch to another panel
(#266)
1 parent d3573a3 commit 67e978d

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/sidebar/handlers/tabs.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,13 @@ function onTabUpdated(tabId, change, tab) {
345345
panel.tabs.splice(index, 1)
346346
}
347347

348-
if (localTab.prevPanelId && localTab.moveTime) {
349-
if (localTab.moveTime + 1000 > Date.now()) {
350-
localTab.panelId = localTab.prevPanelId
351-
panel = this.state.panelsMap[localTab.panelId]
352-
this.actions.saveTabData(localTab)
348+
if (localTab.prevPanelId && localTab.moveTime && localTab.moveTime + 1000 > Date.now()) {
349+
localTab.panelId = localTab.prevPanelId
350+
panel = this.state.panelsMap[localTab.panelId]
351+
this.actions.saveTabData(localTab)
352+
353+
if (localTab.active && panel && panel.index !== this.state.panelIndex) {
354+
this.actions.setPanel(panel.index)
353355
}
354356
}
355357

@@ -629,7 +631,7 @@ function onTabMoved(id, info) {
629631
this.actions.updateTabsTree(a, b)
630632
}
631633

632-
if (this.state.panelsMap[movedTab.panelId].index !== this.state.panelIndex) {
634+
if (this.state.panelsMap[movedTab.panelId].index !== this.state.panelIndex && movedTab.active) {
633635
this.actions.setPanel(this.state.panelsMap[movedTab.panelId].index)
634636
}
635637

0 commit comments

Comments
 (0)