fix: proper error messages for exceptions

Use .name and .message for exceptions.

Author: mbehr1

src/extension/fbaEditor.ts

@@ -117,7 +117,7 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
                             }
                         }
                     } catch (error) {
-                        console.log(`fishbone: extension ${value.id} throws: ${error}`);
+                        console.log(`fishbone: extension ${value.id} throws: ${error.name}:${error.message}`);
                     }
                 }
             });
@@ -233,8 +233,8 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
                 FBAEditorProvider.updateTextDocument(docData, document, { fishbone: e.data, title: e.title, attributes: e.attributes }), 1);
                 */
                     } catch (e) {
-                        console.error(`Fishbone: Could not update document. Changes are lost. Please consider closing and reopening the doc. Error= ${JSON.stringify(e)}.`);
-                        vscode.window.showErrorMessage(`Fishbone: Could not update document. Changes are lost. Please consider closing and reopening the doc. Error= ${JSON.stringify(e)}.`);
+                        console.error(`Fishbone: Could not update document. Changes are lost. Please consider closing and reopening the doc. Error= ${e.name}:${e.message}.`);
+                        vscode.window.showErrorMessage(`Fishbone: Could not update document. Changes are lost. Please consider closing and reopening the doc. Error= ${e.name}:${e.message}.`);
                     }
                     break;
                 case 'sAr':
@@ -279,7 +279,7 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
                                             const json = JSON.parse(result.body);
                                             webviewPanel.webview.postMessage({ type: e.type, res: json, id: e.id });
                                         }).catch(err => {
-                                            webviewPanel.webview.postMessage({ type: e.type, res: { errors: [`request failed with err=${err}`] }, id: e.id });
+                                            webviewPanel.webview.postMessage({ type: e.type, res: { errors: [`request failed with err=${err.name}:${err.message}`] }, id: e.id });
                                         });
                                     }
                                 }
@@ -414,7 +414,7 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
                 yamlObj = {};
             }
         } catch (e) {
-            console.error('Could not get document as json. Content is not valid yaml e= ' + e);
+            console.error(`Could not get document as json. Content is not valid yaml e=${e.name}:${e.message}`);
         }
 
         // only 'title', 'attributes' and 'fishbone' are updated for now. keep the rest:
@@ -490,7 +490,7 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
                                 };
                             }
                         } catch (e) {
-                            console.error(`opening file failed with err:'${e}'`);
+                            console.error(`opening file failed with err:'${e.name}:${e.message}'`);
                         }
                     }
                     return null; // delete the import rc
@@ -532,8 +532,8 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
                                 };
                             }
                         } catch (e) {
-                            console.warn(`re-importing file '${rc.relPath}' failed due to:'${e}'`);
-                            vscode.window.showWarningMessage(`re-importing file '${rc.relPath} failed due to:'${e}'`);
+                            console.warn(`re-importing file '${rc.relPath}' failed due to:'${e.name}:${e.message}'`);
+                            vscode.window.showWarningMessage(`re-importing file '${rc.relPath} failed due to:'${e.name}:${e.message}'`);
                         }
                         console.log('reimport done/failed');
                     } else {
@@ -564,8 +564,8 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
         } catch (e) {
             // need to remove this one from the queue
             docData.editsPending.shift();
-            console.error(`storing as YAML failed. Error=${e}`);
-            vscode.window.showErrorMessage(`Fishbone: Could not update document. Changes are lost. Please consider closing and reopening the doc. Storing as YAML failed. Error=${e}`);
+            console.error(`storing as YAML failed. Error=${e.name}:${e.message}`);
+            vscode.window.showErrorMessage(`Fishbone: Could not update document. Changes are lost. Please consider closing and reopening the doc. Storing as YAML failed. Error=${e.name}:${e.message}`);
             return false;
         }
         console.warn(`FBAEditorProvider.processEditsPendingQueue will apply edit with size=${edit.size}, editsPending.length=${docData.editsPending.length} version=${document.version}`);
@@ -706,10 +706,9 @@ export class FBAEditorProvider implements vscode.CustomTextEditorProvider, vscod
 
             return { attributes: yamlObj?.attributes, fishbone: yamlObj.fishbone, title: yamlObj.title || '<please add title to .fba>' };
         } catch (e) {
-            vscode.window.showErrorMessage(`Fishbone: Could not get document as yaml. Content is not valid yaml. Error= ${e}`);
-            throw new Error('Could not get document as yaml. Content is not valid yaml e= ' + e);
+            vscode.window.showErrorMessage(`Fishbone: Could not get document as yaml. Content is not valid yaml. Error= ${e.name}:${e.message}`);
+            throw new Error(`Fishbone: Could not get document as yaml. Content is not valid yaml. Error= ${e.name}:${e.message}`);
         }
-        return { title: '<error>' };
     }
 
     /**