Merge pull request #179 from mattrubin/hotfix

Ignore un-deserializable tokens in allPersistentTokens()

Author: mattrubin

Sources/Keychain.swift

@@ -47,7 +47,12 @@ public final class Keychain {
     ///
     /// - throws: A `Keychain.Error` if an error occurred.
     public func allPersistentTokens() throws -> Set<PersistentToken> {
-        return Set(try allKeychainItems().map(PersistentToken.init(keychainDictionary:)))
+        let allItems = try allKeychainItems()
+        // This code intentionally ignores items which fail deserialization, instead opting to return as many readable
+        // tokens as possible.
+        // TODO: Restore deserialization error handling, in a way that provides info on the failure reason and allows
+        //       the caller to choose whether to fail completely or recover some data.
+        return Set(allItems.flatMap({ try? PersistentToken.init(keychainDictionary:$0) }))
     }
 
     // MARK: Write

Tests/KeychainTests.swift

@@ -231,7 +231,8 @@ class KeychainTests: XCTestCase {
         let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)
 
         XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
-        XCTAssertThrowsError(try keychain.allPersistentTokens())
+        // TODO: Restore deserialization error handling in allPersistentTokens()
+//        XCTAssertThrowsError(try keychain.allPersistentTokens())
 
         XCTAssertNoThrow(try deleteKeychainItem(forPersistentRef: persistentRef),
                          "Failed to delete the test token from the keychain. This may cause future test runs to fail.")
@@ -247,7 +248,8 @@ class KeychainTests: XCTestCase {
         let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)
 
         XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
-        XCTAssertThrowsError(try keychain.allPersistentTokens())
+        // TODO: Restore deserialization error handling in allPersistentTokens()
+//        XCTAssertThrowsError(try keychain.allPersistentTokens())
 
         XCTAssertNoThrow(try deleteKeychainItem(forPersistentRef: persistentRef),
                          "Failed to delete the test token from the keychain. This may cause future test runs to fail.")
@@ -264,7 +266,8 @@ class KeychainTests: XCTestCase {
         let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)
 
         XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
-        XCTAssertThrowsError(try keychain.allPersistentTokens())
+        // TODO: Restore deserialization error handling in allPersistentTokens()
+//        XCTAssertThrowsError(try keychain.allPersistentTokens())
 
         XCTAssertNoThrow(try deleteKeychainItem(forPersistentRef: persistentRef),
                          "Failed to delete the test token from the keychain. This may cause future test runs to fail.")
@@ -281,7 +284,8 @@ class KeychainTests: XCTestCase {
         let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)
 
         XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
-        XCTAssertThrowsError(try keychain.allPersistentTokens())
+        // TODO: Restore deserialization error handling in allPersistentTokens()
+//        XCTAssertThrowsError(try keychain.allPersistentTokens())
 
         XCTAssertNoThrow(try deleteKeychainItem(forPersistentRef: persistentRef),
                          "Failed to delete the test token from the keychain. This may cause future test runs to fail.")