fix(drag): style assignment for dragged element on IE #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 195 195
Branches 19 19
=====================================
Hits 195 195
Continue to review full report at Codecov.
|
|
Awesome, thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently setting a style property to null doesn't actually remove it in IE11.
Tested with the latest versions of IE, Chrome and Firefox.
Apparently known, but still occurring:
angular/angular#7916
This also fixes the similar issue with angular-calendar, allowing it to be used normally with draggable events in IE.
Fixes https://github.com/mattlewis92/angular-draggable-droppable/issues/29