Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(week-view): add ability to customise document cursor when resizing events #1613

Merged

Conversation

brutusmcforce
Copy link
Contributor

Hi friends,

I need to set custom cursors for the resizable elements in the calendar so I've added properties for them on the day and week views.

I could not find any docs on any preferred way to make pull requests so I hope this is fine.

@brutusmcforce
Copy link
Contributor Author

@mattlewis92 Any opinions on this?

Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply on this one, LGTM!

@mattlewis92 mattlewis92 changed the title feat(calendar): ability to set resizeCursors for resizable elements feat(week-view): add ability to customise document cursor when resizing events Dec 11, 2022
@mattlewis92 mattlewis92 enabled auto-merge (squash) December 11, 2022 14:16
@codecov-commenter
Copy link

Codecov Report

Merging #1613 (685f263) into main (03f5d74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1613   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          39       39           
  Lines         678      678           
  Branches      143      143           
=======================================
  Hits          661      661           
  Misses          1        1           
  Partials       16       16           
Impacted Files Coverage Δ
...dar/src/modules/day/calendar-day-view.component.ts 100.00% <ø> (ø)
...r/src/modules/week/calendar-week-view.component.ts 97.05% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattlewis92 mattlewis92 merged commit 5135590 into mattlewis92:main Dec 11, 2022
@mattlewis92
Copy link
Owner

Released to npm as 0.31.0 🥳 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants